DE-NDS: the collection had no id - #246
Merged
Merged
Conversation
This was referenced Sep 11, 2026
ivorbosloper
force-pushed
the
split/de_nds
branch
from
September 12, 2026 12:50
8a4bda6 to
13991fe
Compare
Nothing mapped to `id`, so the base converter's unlisted-column drop wrote a file without one, and it validated. The row index identifies the field. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DVx9uQV2QPM8ecPAY3ZjXG
ivorbosloper
force-pushed
the
split/de_nds
branch
from
September 12, 2026 15:10
13991fe to
7e5c7ac
Compare
m-mohr
approved these changes
Sep 13, 2026
m-mohr
left a comment
m-mohr
left a comment
Contributor
There was a problem hiding this comment.
Lgtm, maybe we should discuss how we handle ids in general (stable vs generic made up IDs)
Collaborator
Author
Yes. A valid fiboa file has some unique id. If the source lacks a unique id, we can generate it. Can be the order in the source file (1..n), or generating a UUID (not stable), or calculating a geohash. But this option is simplest and stable. |
Contributor
|
Moved discussion to #282 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing mapped to
id, so the unlisted-column drop wrote a file without one — and it validated. The row index identifies the field now. Same shape as #244 and #245; the guard is in #265.🤖 Generated with Claude Code
https://claude.ai/code/session_01DVx9uQV2QPM8ecPAY3ZjXG