EC-EE: require only what the source actually fills - #247
Merged
Merged
Conversation
ivorbosloper
force-pushed
the
split/ec_ee
branch
from
September 12, 2026 12:50
8330fdd to
6939fac
Compare
The converter's missing_schemas marked properties as required that the release does not fill for every parcel, so the conversion failed at write time — one column per run, after the whole file had been read. Checking this needs the whole source rather than the 100-row fixture: a column the source only sometimes fills passes the test and fails the full run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DVx9uQV2QPM8ecPAY3ZjXG
ivorbosloper
force-pushed
the
split/ec_ee
branch
from
September 12, 2026 15:10
6939fac to
e78bed7
Compare
This was referenced Sep 12, 2026
saidy-moregeo
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
missing_schemasmarked properties required that the release does not fill for every parcel, so the conversion died at write time, one column per run, after the whole file had been read. Also names the shapefile inside the archive and migrates the year column the release actually has.A 100-row fixture cannot catch this: check the whole source (
gpd.read_file(...).isna().sum()) rather than peeling columns one run at a time.