Skip to content

DE-NDS: the collection had no id #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivorbosloper merged 2 commits into from
Sep 13, 2026
Merged

DE-NDS: the collection had no id #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e5c7ac
DE-NDS: the collection had no id
ivorbosloper Sep 11, 2026
55b57a5
Merge branch 'main' into split/de_nds
ivorbosloper Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- ES-CL: the ITACyL server is https-only, the 2025 shapefiles sit in province subfolders, and C_REFREC is the identifier
- A test refuses a fixture above 5 MB, committed or merely lying in the fixture folder, because a failing convert test downloads the real source there
- ES-MD: find RECINTO.shp wherever the archive puts it
- DE-NDS: give the collection an id (the row index), which it was published without
- DE-BB: ref_ident holds the FLIK (field block reference), not a farmer, and the shapefile is cp1252
- Update vecorel-cli to v0.2.17:
- GeoJSON is read as UTF-8 as the format mandates, instead of the platform locale (cp1252 on Windows mangled umlauts)
Expand Down
4 changes: 4 additions & 0 deletions fiboa_cli/datasets/de_nds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@ class Converter(AdminConverterMixin, AddHCATMixin, FiboaBaseConverter):

# https://www.sla.niedersachsen.de/download/141235/Verzeichnis_Nutzungscodes.xlsx
ec_mapping_csv = "de.csv"
# The shapefile has no unique key: 880,581 features share 874,222 distinct
# (FLIK, SCHLAGNR) pairs, so the row index is the only identifier available.
index_as_id = True
columns = {
"id": "id",
"geometry": "geometry",
"FLIK": "flik",
"SCHLAGNR": "subfield_id",
Expand Down
Loading