Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Connect opt-in Affordance sampling to the
run-envoffline Task Program collection workflow. Sequential Pick/Place episodes now require measured target proximity, gripper release, and object stability before their rows can be saved. With four environments and a quota of five episodes, the final batch saves only enough accepted rows to reach five confirmed commits.Scope is Affordance-only offline collection. Online collection, trajectory generation/coverage, parallel Task Program segments, and asynchronous receipt support are excluded. No dependency changes or linked issue.
Per-episode LeRobot finalize/reload adds I/O cost. Receipts provide same-process deduplication, not cross-process recovery or an atomic transaction across dataset and trajectory outputs.
Type of change
Validation
black==26.3.1withblack ., structural checks, context map check, andgit diff --check: passed.Draft validation limit: the real simulation smoke run failed during startup because the available DexSim build lacks
WorldConfig.log_startup_info. The excluded existing config test requiresDLSSConfig.frame_time_delta_ms, also absent in that build. Physical rollout success and yield remain unverified; mock tests and real LeRobot persistence tests do not establish physical task success.Checklist
black .command to format the code base.python docs/scripts/check_api_docs.py).