Add simulation-level Affordance sampling - #644
Merged
Merged
Conversation
|
Co-authored-by: matafela <chenjian@dexforce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds reproducible, Affordance-owned pose sampling to simulation Atomic Actions. It uses PR #637 only as a design reference and delivers the implementation on a fresh branch based on
main.Key changes:
AffordanceSamplingContext,AffordancePoseCandidates, and the unified, ownedAffordanceSampleresult;The review follow-up also deep-copies nested sampling metadata, updates the PickUp replan integration test to the
AffordanceSamplecontract, and removes tutorial-focused sampling tests in favor of production-contract tests plus static tutorial validation.Dependencies: none.
Refs #637
Type of change
Screenshots
Not applicable.
Validation
black .— 1050 files left unchanged with Black 26.3.1black --check --diff --color ./— passedpytest -q tests/sim/atomic_actions --tb=short— 834 passed, 1 skipped, 3 deselectedpytest -q tests/lab/task_program/test_semantic_compiler.py --tb=short— 31 passedpython docs/scripts/check_api_docs.py— 2081/2081 exports documentedpython .agents/skills/project-dev-context/scripts/context.py check— passedpytest -q -c /dev/null --noconftest tests/test_agent_context_map.py tests/test_agent_context_tools.py— 23 passedpython -m py_compilefor the seven sampling tutorials and sharedtutorial_utils.py— passedThe interactive GPU simulation tutorials were not launched in this non-interactive validation environment.
Checklist
black .command to format the code base.python docs/scripts/check_api_docs.py).