Add immutable per-party GG20 transcript modes - #9
Open
lrsaturnino wants to merge 5 commits into
Open
lrsaturnino wants to merge 5 commits into
lrsaturnino wants to merge 5 commits into
Conversation
mswilkison
reviewed
Sep 18, 2026
mswilkison
left a comment
mswilkison
left a comment
There was a problem hiding this comment.
Found one P1 compatibility regression in the legacy T1 bound; see the inline comment.
Comment on lines
+261
to
+262
| q6 := new(big.Int).Mul(q3, q3) | ||
| maxT1 = new(big.Int).Add(pk.N, q6) |
There was a problem hiding this comment.
[P1] Account for the historical witness range in the legacy T1 bound
PR #9 breaks mixed-version legacy signing because historical BobMid and BobMidWC sample betaPrm (the proof’s y) below pkA.N, not q^5 (see the historical implementation). Consequently, honest T1 = e*y + gamma almost always exceeds N + q^6, causing AliceEnd/AliceEndWC to reject historical proofs and abort signing. Derive the finite legacy bound from the historical witness range and add coverage using historical BobMid output; the current compatibility vectors fix y = 11 and miss this failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a draft because the transcript boundary needs independent cryptographic review before release use.
Verification
go test ./...go test -race ./tss ./crypto/dlnproof ./crypto/mta ./crypto/paillier ./crypto/schnorr ./ecdsa/keygen ./ecdsa/signinggo vet ./...