ci: run checks on every pull request, not just those targeting master - #24
piotr-roslaniec wants to merge 1 commit into
Conversation
Both workflows filtered pull_request events to base branch master. This fork stacks pull requests on each other's branches, so every stacked PR and every PR targeting dev ran with no checks at all: #17 and #23 currently report no checks, and the whole in-flight batch targeting dev is covered only by locally-run tests. Drop the pull_request branch filter so any PR gets CI regardless of base, and add dev to the push trigger so the integration branch is covered on merge.
|
Worth flagging a limit of this PR that isn't obvious: merging it does not by itself give #17 and #23 CI. Because GitHub resolves a Suggested merge order, which needs no branch surgery:
Retargeting is content-neutral here because the stack is a linear, fast-forwardable chain: Alternative if you'd rather not retarget: merge |
Problem
test.ymlandgofmt.ymlboth filterpull_requestevents to base branchmaster:This fork stacks PRs on each other's branches, and the whole in-flight batch targets
dev. For apull_requestevent GitHub uses the workflow from the base branch, so with this filter any PR not targetingmastergets zero checks.Observable right now: #17 and #23 both report
no checks reported on the ... branch. That is a trigger gap, not queue lag — #11 and #9 look green only because their runs were triggered back when they targetedmaster(verified: those runs'headShastill match the current heads, so the results are valid, just not reproducible for new pushes).Net effect: the constant-time stack is about to be merged on locally-run tests as the only evidence.
Change
pull_requestbranch filter entirely, so every PR gets CI whatever it targets. A fixed allow-list would need updating for each new stacked base branch and would silently fail the same way again.devto thepushtrigger so the integration branch is covered on merge.Notes
devbecause that is where the gap bites, and becausepull_requestresolves workflows from the base branch — landing it ondevis what gives the in-flight batch coverage.masterpicks it up wheneverdevmerges forward.dev's copy of the workflow still has the old filter until this merges. Expect checks to start appearing on subsequent PRs.