Support streaming write into FSTree - #4171
Open
cthulhu-rider wants to merge 6 commits into
Open
cthulhu-rider wants to merge 6 commits into
cthulhu-rider wants to merge 6 commits into
Conversation
cthulhu-rider
force-pushed
the
storage-put-stream
branch
from
September 10, 2026 16:49
98cb13d to
9303d1f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4171 +/- ##
==========================================
+ Coverage 30.83% 31.08% +0.24%
==========================================
Files 675 674 -1
Lines 41101 40844 -257
==========================================
+ Hits 12675 12695 +20
+ Misses 28426 28149 -277 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cthulhu-rider
marked this pull request as ready for review
September 10, 2026 17:05
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
September 10, 2026 17:05
cthulhu-rider
marked this pull request as draft
September 11, 2026 08:17
cthulhu-rider
force-pushed
the
storage-put-stream
branch
from
September 11, 2026 09:52
9303d1f to
3cd170b
Compare
It's unused if there are write problems. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Previously, linkat syscall error had 'unix write' context. Also, incomplete write case had 'unix write: incomplete unix write' text which is tautology. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Refactoring purpose. Close statement appears multiple times now, but due to this the logic is more readable. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
storage-put-stream
branch
from
September 11, 2026 09:53
3cd170b to
f0b5d0e
Compare
cthulhu-rider
marked this pull request as ready for review
September 11, 2026 11:54
Make behavior as close to Put as possible. To be used for #4157. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
OS-independent and more familiar. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Error type supports inversion, so casting is not needed. This changes the behavior for 404 and 'no space left' errors outside fs.PathError, but system functions shouldn't return them in vain anyway. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
storage-put-stream
branch
from
September 14, 2026 09:10
cf04564 to
8575d7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.