Support streaming write into write cache - #4178
Draft
cthulhu-rider wants to merge 8 commits into
Draft
cthulhu-rider wants to merge 8 commits into
cthulhu-rider wants to merge 8 commits into
Conversation
cthulhu-rider
commented
Sep 14, 2026
cthulhu-rider
commented
Contributor
- based on and blocked by Support streaming write into FSTree #4171 (last 2 commits)
cthulhu-rider
force-pushed
the
storage-put-stream-continue
branch
8 times, most recently
from
September 15, 2026 11:01
22fba6c to
573e6b8
Compare
It's unused if there are write problems. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Previously, linkat syscall error had 'unix write' context. Also, incomplete write case had 'unix write: incomplete unix write' text which is tautology. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Refactoring purpose. Close statement appears multiple times now, but due to this the logic is more readable. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
storage-put-stream-continue
branch
from
September 15, 2026 11:57
573e6b8 to
88ce372
Compare
Make behavior as close to Put as possible. To be used for #4157. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
OS-independent and more familiar. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Error type supports inversion, so casting is not needed. This changes the behavior for 404 and 'no space left' errors outside fs.PathError, but system functions shouldn't return them in vain anyway. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Make behavior as close to Put as possible. To be used for #4157. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
storage-put-stream-continue
branch
from
September 15, 2026 15:51
88ce372 to
01de14d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.