Add spatial morphing inputs and kgos - #146
Open
gavinevans wants to merge 2 commits into
Open
gavinevans wants to merge 2 commits into
gavinevans wants to merge 2 commits into
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to metoppv/improver#2441
This PR adds inputs and kgos associated with the SpatialMorphing plugin and CLI. The plot below shows the input and outputs from the SpatialMorphing CLI. source a is a nowcast, source b is a MOGREPS-UK realization. The "no_implied_transitions_kgo.nc" shows the result where the json file defining the transitions has been modified, so that the forecast period between processed here is after the transition period, meaning that the MOGREPS-UK realization is returned. The known good outputs show the output at an interpolated timestep (with and without quantile mapping) when a linear morphing method is used. This linear morphing method is included for demonstration as Google FILM is a bit heavier, computationally to run as part of the acceptance tests. Due to the use of linear weighting and how the quantile mapping is configured (also using a linear blend of the forecasts as a reference), the quantile mapping has not effect.
The plot below shows the same results when Google FILM is used as the morphing method, rather than using a linear approach. The Google FILM morphing method generally results in reduced extent to the precipitation, which would be the hoped for result, given that the linear blending approach will retain the spatial extent of the precipitation found in the two forecast sources. In this case, the quantile mapping has a clear impact with some evidence that it has further slightly reduced the abundance of precipitating pixels.
For completeness, I've added testing that

smoothsteptransition weights scheme, which results in no discernible difference relative to thelineartransition weights scheme in this example.