Add acceptance output for spatial morphing suppression - #149
Open
gavinevans wants to merge 1 commit into
Open
gavinevans wants to merge 1 commit into
gavinevans wants to merge 1 commit into
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to metoppv/improver#2451
Note that this PR is currently pointing at #146, so that it's clear what is PR contains. The changes can also be compared with the prior quantile mapping approach shown in #146.
This PR removes the quantile mapping kgo, as the quantile mapping has been removed from the spatial morphing CLI and replaced with an
apply_suppressionoption. A new kgo is therefore added for this suppression option and a json file linked with this new suppression option is also included.KGO produced using linear morphing method
KGO produced using Google FILM method
