fix(tab-navigation): overflow menu for route-backed tabs without ids - #171
Merged
Merged
Conversation
… no id Route-backed tabs are usually declared with only a route and label. The overflow calculation compared tab ids, so every tab collapsed onto undefined: the visible and overflow sets both matched all tabs and the More menu never worked while the tab list clipped the trailing tabs. Derive the identity from id, route or key and cover the route-only case in the integration test.
This was referenced Sep 9, 2026
Merged
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TabNavigationmoves tabs that do not fit into a "More" dropdown, but the overflow bookkeeping keyed everything ontab.id. Route-backed tabs (the common shape in Fleet-Ops detail panels:{ route, label }) have noid, so:visibleTabIdsandoverflowTabIdswere arrays ofundefined, which made both the visible filter and the overflow filter match every tab;.tab-items { overflow: hidden }), so trailing tabs were unreachable and the More menu never appeared.This change derives a tab's identity from
id, thenroute, thenkey, and uses it consistently for the active-tab state, overflow calculation and keyboard navigation. Tabs that already passidare unaffected.Tests
eslintandprettierpass on the touched files.