Release v0.4.0 - #172
Merged
Merged
Conversation
… no id Route-backed tabs are usually declared with only a route and label. The overflow calculation compared tab ids, so every tab collapsed onto undefined: the visible and overflow sets both matched all tabs and the More menu never worked while the tab list clipped the trailing tabs. Derive the identity from id, route or key and cover the route-only case in the integration test.
…dentity fix(tab-navigation): overflow menu for route-backed tabs without ids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v0.4.0 fixes TabNavigation overflow for route-backed tabs without explicit IDs and completes the release workflow configuration for
release/v*branches.idtoroutetokey, keeping overflowed tabs accessible in the More menu and consistent with active state and keyboard navigation.package.jsonandRELEASE.mdon v0.4.0.release/v*and legacydev-v*PRs targetingmaincall the shared tagger, which validates the version and notes and tags the merge commit. Manual recovery remains available.contents: writeto GitHub Release creation andpackages: writeto GitHub package publishing, with read-only contents access for other CI jobs.The larger coverage, signature pad, and component playground release remains in v0.4.1 (#173, replacing #169).
Validation: actionlint 1.7.12 passes for all three workflows. Local checks pass for seven tagging scenarios, CI branch/tag triggers, publishing permissions and guards, token inheritance, and matching release metadata. Repository access to the organization release and npm secret names is confirmed. End-to-end tagging and publishing have not been executed; they occur after release merge. CI results are reported by the PR checks.