fix(firestore,android): abort timed-out transactions without crashing on a later get

packages/cloud_firestore/cloud_firestore/android/src/main/java/io/flutter/plugins/firebase/firestore/FlutterFirebaseFirestorePlugin.java

@@ -635,6 +635,8 @@ public void transactionGet(
                     DocumentSnapshot.ServerTimestampBehavior.NONE));
           } catch (Exception e) {
             ExceptionConverter.sendErrorToFlutter(result, e);
+          } catch (Throwable t) {
+            ExceptionConverter.sendErrorToFlutter(result, new Exception(t));
           }
         });
   }

packages/cloud_firestore/cloud_firestore/android/src/main/java/io/flutter/plugins/firebase/firestore/streamhandler/TransactionStreamHandler.java

@@ -87,11 +87,15 @@ public void onListen(Object arguments, EventSink events) {
 
               try {
                 if (!semaphore.tryAcquire(timeout, TimeUnit.MILLISECONDS)) {
-                  return FlutterFirebaseFirestoreTransactionResult.failed(
+                  // Throw a non-FirebaseFirestoreException so the Android SDK
+                  // does not retry or commit. Returning a failed result object
+                  // makes apply() succeed, which commits and then crashes a later
+                  // transaction.get (see #18666).
+                  throw new RuntimeException(
                       new FirebaseFirestoreException("timed out", Code.DEADLINE_EXCEEDED));
                 }
               } catch (InterruptedException e) {
-                return FlutterFirebaseFirestoreTransactionResult.failed(
+                throw new RuntimeException(
                     new FirebaseFirestoreException("interrupted", Code.DEADLINE_EXCEEDED));
               }
 

packages/cloud_firestore/cloud_firestore/example/integration_test/transaction_e2e.dart

@@ -302,6 +302,34 @@ void runTransactionTests() {
         skip: kIsWeb || defaultTargetPlatform == TargetPlatform.windows,
       );
 
+      test(
+        'should not crash when a get is issued after the transaction timeout',
+        () async {
+          final DocumentReference<Map<String, dynamic>> first =
+              await initializeTest('timeout-second-get-1');
+          final DocumentReference<Map<String, dynamic>> second =
+              await initializeTest('timeout-second-get-2');
+          await first.set(<String, Object>{'v': 1});
+          await second.set(<String, Object>{'v': 2});
+
+          await expectLater(
+            firestore.runTransaction(
+              (Transaction transaction) async {
+                await transaction.get(first);
+                await Future<void>.delayed(const Duration(seconds: 2));
+                await transaction.get(second);
+              },
+              timeout: const Duration(seconds: 1),
+            ),
+            throwsA(
+              isA<FirebaseException>()
+                  .having((e) => e.code, 'code', 'deadline-exceeded'),
+            ),
+          );
+        },
+        skip: kIsWeb || defaultTargetPlatform != TargetPlatform.android,
+      );
+
       test('should throw with exception', () async {
         try {
           await firestore.runTransaction((Transaction transaction) async {