Skip to content

fix(firestore,android): abort timed-out transactions without crashing on a later get - #18668

Merged
SelaseKay merged 1 commit into
mainfrom
firestore_18666
Sep 10, 2026
Merged

fix(firestore,android): abort timed-out transactions without crashing on a later get#18668
SelaseKay merged 1 commit into
mainfrom
firestore_18666

Conversation

@SelaseKay

Copy link
Copy Markdown
Contributor

Description

Android runTransaction timed out by returning a failed result from the native update callback. The Firestore SDK treated that as success, committed, and a later transaction.get hit ensureCommitNotCalled. AssertionError is not an Exception, so the process died instead of Dart seeing deadline-exceeded.

Abort the callback with a non-retryable error (still mapped to deadline-exceeded) and catch Throwable in transactionGet.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

… on a later get

Returning a failed result from the native update callback lets the Android SDK commit, so a subsequent transaction.get hits ensureCommitNotCalled and kills the process. Throw instead so Dart still sees deadline-exceeded.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@russellwheatley russellwheatley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SelaseKay
SelaseKay merged commit 168172a into main Sep 10, 2026
51 of 53 checks passed
@SelaseKay
SelaseKay deleted the firestore_18666 branch September 10, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cloud_firestore][Android]: Transaction callback timeout can cause fatal assertion on subsequent read

4 participants