Skip to content

fix(auth): stop dropping the user identifier from localized sign-in labels #2501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
demolaf wants to merge 1 commit into
base: ci/run-android-lint-in-the-build
Choose a base branch
from
Draft

fix(auth): stop dropping the user identifier from localized sign-in labels #2501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion auth/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,11 @@ android {
warningsAsErrors = true
abortOnError = true

// Pre-existing debt only: 168 localization findings (CPRN-432) and 12 Compose
// Pre-existing debt only: 43 MissingTranslation findings (CPRN-432) and 12 Compose
// correctness findings (CPRN-436). Every entry is suppressed; new ones still fail.
// The 43 are strings the Compose rewrite added to values/strings.xml and never sent
// for translation — real UI copy in 50 languages, so they clear when translations
// land, not by editing anything here. Delete this file once they do.
baseline = file("lint-baseline.xml")
}

Expand Down
1,687 changes: 16 additions & 1,671 deletions auth/lint-baseline.xml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions ...in/java/com/firebase/ui/auth/configuration/string_provider/DefaultAuthUIStringProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ class DefaultAuthUIStringProvider(
/**
* Allows overriding locale.
*/
// AppBundleLocaleChanges tells app modules to pair a dynamic locale change with a Play Core
// language download. A library cannot: the bundle configuration and any Play Core dependency
// belong to the app that embeds us, so there is nothing here to fix.
@Suppress("AppBundleLocaleChanges")
private val localizedContext = locale?.let { locale ->
context.createConfigurationContext(
Configuration(context.resources.configuration).apply {
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-ar/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
<string name="fui_resend_verification_email_action">إعادة إرسال بريد التحقق</string>
<string name="fui_secret_key_label">المفتاح السري</string>
<string name="fui_sign_out_action">تسجيل الخروج</string>
<string name="fui_signed_in_as">مسجل الدخول باسم</string>
<string name="fui_signed_in_as">مسجل الدخول باسم %1$s</string>
<string name="fui_skip_action">تخطي</string>
<string name="fui_use_different_method_action">استخدم طريقة أخرى</string>
<string name="fui_verification_code_label">رمز التحقق</string>
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-b+es+419/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<string name="fui_name_hint">Nombre y apellido</string>
<string name="fui_button_text_save">Guardar</string>
<string name="fui_progress_dialog_signing_up">Registrando…</string>
<plurals name="fui_error_weak_password"> <item quantity="one">La contraseña no es lo suficientemente segura. Usa al menos %1$d carácter y una combinación de letras y números</item> <item quantity="other">La contraseña no es lo suficientemente segura. Usa al menos %1$d caracteres y una combinación de letras y números</item> </plurals>
<plurals name="fui_error_weak_password"> <item quantity="one">La contraseña no es lo suficientemente segura. Usa al menos %1$d carácter y una combinación de letras y números</item> <item quantity="many">La contraseña no es lo suficientemente segura. Usa al menos %1$d de caracteres y una combinación de letras y números</item> <item quantity="other">La contraseña no es lo suficientemente segura. Usa al menos %1$d caracteres y una combinación de letras y números</item> </plurals>
<string name="fui_email_account_creation_error">No se pudo registrar la cuenta de correo electrónico</string>
<string name="fui_terms_of_service">Condiciones del Servicio</string>
<string name="fui_privacy_policy">Política de Privacidad</string>
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-bg/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
<string name="fui_resend_verification_email_action">Изпращане на имейл за потвърждение отново</string>
<string name="fui_secret_key_label">Таен ключ</string>
<string name="fui_sign_out_action">Изход</string>
<string name="fui_signed_in_as">Влезли сте като</string>
<string name="fui_signed_in_as">Влезли сте като %1$s</string>
<string name="fui_skip_action">Пропускане</string>
<string name="fui_use_different_method_action">Използване на друг метод</string>
<string name="fui_verification_code_label">Код за потвърждение</string>
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-bn/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
<string name="fui_resend_verification_email_action">যাচাইকরণ ইমেল পুনরায় পাঠান</string>
<string name="fui_secret_key_label">গোপন কী</string>
<string name="fui_sign_out_action">সাইন আউট</string>
<string name="fui_signed_in_as">হিসাবে সাইন ইন করা হয়েছে</string>
<string name="fui_signed_in_as">%1$s হিসাবে সাইন ইন করা হয়েছে</string>
<string name="fui_skip_action">এড়িয়ে যান</string>
<string name="fui_use_different_method_action">একটি ভিন্ন পদ্ধতি ব্যবহার করুন</string>
<string name="fui_verification_code_label">যাচাইকরণ কোড</string>
Expand Down
4 changes: 2 additions & 2 deletions auth/src/main/res/values-ca/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<string name="fui_name_hint">Nom i cognoms</string>
<string name="fui_button_text_save">Desa</string>
<string name="fui_progress_dialog_signing_up">T\'estàs registrant…</string>
<plurals name="fui_error_weak_password"> <item quantity="one">La contrasenya no és prou segura. Utilitza com a mínim %1$d caràcter i combina lletres i números.</item> <item quantity="other">La contrasenya no és prou segura. Utilitza com a mínim %1$d caràcters i combina lletres i números.</item> </plurals>
<plurals name="fui_error_weak_password"> <item quantity="one">La contrasenya no és prou segura. Utilitza com a mínim %1$d caràcter i combina lletres i números.</item> <item quantity="many">La contrasenya no és prou segura. Utilitza com a mínim %1$d de caràcters i combina lletres i números.</item> <item quantity="other">La contrasenya no és prou segura. Utilitza com a mínim %1$d caràcters i combina lletres i números.</item> </plurals>
<string name="fui_email_account_creation_error">No s\'ha pogut registrar el compte de correu electrònic</string>
<string name="fui_terms_of_service">Condicions del servei</string>
<string name="fui_privacy_policy">política de privadesa</string>
Expand Down Expand Up @@ -166,7 +166,7 @@
<string name="fui_resend_verification_email_action">Torna a enviar el correu de verificació</string>
<string name="fui_secret_key_label">Clau secreta</string>
<string name="fui_sign_out_action">Tanca la sessió</string>
<string name="fui_signed_in_as">Has iniciat sessió com a</string>
<string name="fui_signed_in_as">Has iniciat sessió com a %1$s</string>
<string name="fui_skip_action">Omet</string>
<string name="fui_use_different_method_action">Utilitza un mètode diferent</string>
<string name="fui_verification_code_label">Codi de verificació</string>
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-cs/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
<string name="fui_resend_verification_email_action">Znovu odeslat ověřovací e-mail</string>
<string name="fui_secret_key_label">Tajný klíč</string>
<string name="fui_sign_out_action">Odhlásit se</string>
<string name="fui_signed_in_as">Přihlášen jako</string>
<string name="fui_signed_in_as">Přihlášen jako %1$s</string>
<string name="fui_skip_action">Přeskočit</string>
<string name="fui_use_different_method_action">Použít jinou metodu</string>
<string name="fui_verification_code_label">Ověřovací kód</string>
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-da/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
<string name="fui_resend_verification_email_action">Send bekræftelsesemail igen</string>
<string name="fui_secret_key_label">Hemmelig nøgle</string>
<string name="fui_sign_out_action">Log ud</string>
<string name="fui_signed_in_as">Logget ind som</string>
<string name="fui_signed_in_as">Logget ind som %1$s</string>
<string name="fui_skip_action">Spring over</string>
<string name="fui_use_different_method_action">Brug en anden metode</string>
<string name="fui_verification_code_label">Bekræftelseskode</string>
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-el/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
<string name="fui_resend_verification_email_action">Επαναποστολή email επαλήθευσης</string>
<string name="fui_secret_key_label">Μυστικό κλειδί</string>
<string name="fui_sign_out_action">Αποσύνδεση</string>
<string name="fui_signed_in_as">Συνδεδεμένος ως</string>
<string name="fui_signed_in_as">Συνδεδεμένος ως %1$s</string>
<string name="fui_skip_action">Παράλειψη</string>
<string name="fui_use_different_method_action">Χρήση διαφορετικής μεθόδου</string>
<string name="fui_verification_code_label">Κωδικός επαλήθευσης</string>
Expand Down
4 changes: 2 additions & 2 deletions auth/src/main/res/values-en-rAU/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@

<string name="fui_confirm_password_hint">Confirm password</string>
<string name="fui_passwords_do_not_match">Passwords do not match</string>
<string name="fui_error_password_too_short">Password must be at least %1$d characters long</string>
<string name="fui_error_password_too_short" tools:ignore="PluralsCandidate">Password must be at least %1$d characters long</string>
<string name="fui_error_password_missing_uppercase">Password must contain at least one uppercase letter</string>
<string name="fui_error_password_missing_lowercase">Password must contain at least one lowercase letter</string>
<string name="fui_error_password_missing_digit">Password must contain at least one number</string>
Expand Down Expand Up @@ -165,7 +165,7 @@
<string name="fui_resend_verification_email_action">Resend verification email</string>
<string name="fui_secret_key_label">Secret key</string>
<string name="fui_sign_out_action">Sign out</string>
<string name="fui_signed_in_as">Signed in as</string>
<string name="fui_signed_in_as">Signed in as %1$s</string>
<string name="fui_skip_action">Skip</string>
<string name="fui_use_different_method_action">Use a different method</string>
<string name="fui_verification_code_label">Verification code</string>
Expand Down
4 changes: 2 additions & 2 deletions auth/src/main/res/values-en-rCA/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@

<string name="fui_confirm_password_hint">Confirm password</string>
<string name="fui_passwords_do_not_match">Passwords do not match</string>
<string name="fui_error_password_too_short">Password must be at least %1$d characters long</string>
<string name="fui_error_password_too_short" tools:ignore="PluralsCandidate">Password must be at least %1$d characters long</string>
<string name="fui_error_password_missing_uppercase">Password must contain at least one upper-case letter</string>
<string name="fui_error_password_missing_lowercase">Password must contain at least one lower-case letter</string>
<string name="fui_error_password_missing_digit">Password must contain at least one number</string>
Expand Down Expand Up @@ -165,7 +165,7 @@
<string name="fui_resend_verification_email_action">Resend verification email</string>
<string name="fui_secret_key_label">Secret key</string>
<string name="fui_sign_out_action">Sign out</string>
<string name="fui_signed_in_as">Signed in as</string>
<string name="fui_signed_in_as">Signed in as %1$s</string>
<string name="fui_skip_action">Skip</string>
<string name="fui_use_different_method_action">Use a different method</string>
<string name="fui_verification_code_label">Verification code</string>
Expand Down
4 changes: 2 additions & 2 deletions auth/src/main/res/values-en-rGB/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@

<string name="fui_confirm_password_hint">Confirm password</string>
<string name="fui_passwords_do_not_match">Passwords do not match</string>
<string name="fui_error_password_too_short">Password must be at least %1$d characters long</string>
<string name="fui_error_password_too_short" tools:ignore="PluralsCandidate">Password must be at least %1$d characters long</string>
<string name="fui_error_password_missing_uppercase">Password must contain at least one upper-case letter</string>
<string name="fui_error_password_missing_lowercase">Password must contain at least one lower-case letter</string>
<string name="fui_error_password_missing_digit">Password must contain at least one number</string>
Expand Down Expand Up @@ -165,7 +165,7 @@
<string name="fui_resend_verification_email_action">Resend verification email</string>
<string name="fui_secret_key_label">Secret key</string>
<string name="fui_sign_out_action">Sign out</string>
<string name="fui_signed_in_as">Signed in as</string>
<string name="fui_signed_in_as">Signed in as %1$s</string>
<string name="fui_skip_action">Skip</string>
<string name="fui_use_different_method_action">Use a different method</string>
<string name="fui_verification_code_label">Verification code</string>
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-en-rIE/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
<string name="fui_resend_verification_email_action">Resend verification email</string>
<string name="fui_secret_key_label">Secret key</string>
<string name="fui_sign_out_action">Sign out</string>
<string name="fui_signed_in_as">Signed in as</string>
<string name="fui_signed_in_as">Signed in as %1$s</string>
<string name="fui_skip_action">Skip</string>
<string name="fui_use_different_method_action">Use a different method</string>
<string name="fui_verification_code_label">Verification code</string>
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-en-rIN/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
<string name="fui_resend_verification_email_action">Resend verification email</string>
<string name="fui_secret_key_label">Secret key</string>
<string name="fui_sign_out_action">Sign out</string>
<string name="fui_signed_in_as">Signed in as</string>
<string name="fui_signed_in_as">Signed in as %1$s</string>
<string name="fui_skip_action">Skip</string>
<string name="fui_use_different_method_action">Use a different method</string>
<string name="fui_verification_code_label">Verification code</string>
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-en-rSG/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
<string name="fui_resend_verification_email_action">Resend verification email</string>
<string name="fui_secret_key_label">Secret key</string>
<string name="fui_sign_out_action">Sign out</string>
<string name="fui_signed_in_as">Signed in as</string>
<string name="fui_signed_in_as">Signed in as %1$s</string>
<string name="fui_skip_action">Skip</string>
<string name="fui_use_different_method_action">Use a different method</string>
<string name="fui_verification_code_label">Verification code</string>
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-en-rZA/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
<string name="fui_resend_verification_email_action">Resend verification email</string>
<string name="fui_secret_key_label">Secret key</string>
<string name="fui_sign_out_action">Sign out</string>
<string name="fui_signed_in_as">Signed in as</string>
<string name="fui_signed_in_as">Signed in as %1$s</string>
<string name="fui_skip_action">Skip</string>
<string name="fui_use_different_method_action">Use a different method</string>
<string name="fui_verification_code_label">Verification code</string>
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-es-rAR/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<string name="fui_name_hint">Nombre y apellido</string>
<string name="fui_button_text_save">Guardar</string>
<string name="fui_progress_dialog_signing_up">Registrando…</string>
<plurals name="fui_error_weak_password"> <item quantity="one">La contraseña no es lo suficientemente segura. Usa al menos %1$d carácter y una combinación de letras y números</item> <item quantity="other">La contraseña no es lo suficientemente segura. Usa al menos %1$d caracteres y una combinación de letras y números</item> </plurals>
<plurals name="fui_error_weak_password"> <item quantity="one">La contraseña no es lo suficientemente segura. Usa al menos %1$d carácter y una combinación de letras y números</item> <item quantity="many">La contraseña no es lo suficientemente segura. Usa al menos %1$d de caracteres y una combinación de letras y números</item> <item quantity="other">La contraseña no es lo suficientemente segura. Usa al menos %1$d caracteres y una combinación de letras y números</item> </plurals>
<string name="fui_email_account_creation_error">No se pudo registrar la cuenta de correo electrónico</string>
<string name="fui_terms_of_service">Condiciones del Servicio</string>
<string name="fui_privacy_policy">Política de Privacidad</string>
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-es-rBO/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<string name="fui_name_hint">Nombre y apellido</string>
<string name="fui_button_text_save">Guardar</string>
<string name="fui_progress_dialog_signing_up">Registrando…</string>
<plurals name="fui_error_weak_password"> <item quantity="one">La contraseña no es lo suficientemente segura. Usa al menos %1$d carácter y una combinación de letras y números</item> <item quantity="other">La contraseña no es lo suficientemente segura. Usa al menos %1$d caracteres y una combinación de letras y números</item> </plurals>
<plurals name="fui_error_weak_password"> <item quantity="one">La contraseña no es lo suficientemente segura. Usa al menos %1$d carácter y una combinación de letras y números</item> <item quantity="many">La contraseña no es lo suficientemente segura. Usa al menos %1$d de caracteres y una combinación de letras y números</item> <item quantity="other">La contraseña no es lo suficientemente segura. Usa al menos %1$d caracteres y una combinación de letras y números</item> </plurals>
<string name="fui_email_account_creation_error">No se pudo registrar la cuenta de correo electrónico</string>
<string name="fui_terms_of_service">Condiciones del Servicio</string>
<string name="fui_privacy_policy">Política de Privacidad</string>
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-es-rCL/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<string name="fui_name_hint">Nombre y apellido</string>
<string name="fui_button_text_save">Guardar</string>
<string name="fui_progress_dialog_signing_up">Registrando…</string>
<plurals name="fui_error_weak_password"> <item quantity="one">La contraseña no es lo suficientemente segura. Usa al menos %1$d carácter y una combinación de letras y números</item> <item quantity="other">La contraseña no es lo suficientemente segura. Usa al menos %1$d caracteres y una combinación de letras y números</item> </plurals>
<plurals name="fui_error_weak_password"> <item quantity="one">La contraseña no es lo suficientemente segura. Usa al menos %1$d carácter y una combinación de letras y números</item> <item quantity="many">La contraseña no es lo suficientemente segura. Usa al menos %1$d de caracteres y una combinación de letras y números</item> <item quantity="other">La contraseña no es lo suficientemente segura. Usa al menos %1$d caracteres y una combinación de letras y números</item> </plurals>
<string name="fui_email_account_creation_error">No se pudo registrar la cuenta de correo electrónico</string>
<string name="fui_terms_of_service">Condiciones del Servicio</string>
<string name="fui_privacy_policy">Política de Privacidad</string>
Expand Down
2 changes: 1 addition & 1 deletion auth/src/main/res/values-es-rCO/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<string name="fui_name_hint">Nombre y apellido</string>
<string name="fui_button_text_save">Guardar</string>
<string name="fui_progress_dialog_signing_up">Registrando…</string>
<plurals name="fui_error_weak_password"> <item quantity="one">La contraseña no es lo suficientemente segura. Usa al menos %1$d carácter y una combinación de letras y números</item> <item quantity="other">La contraseña no es lo suficientemente segura. Usa al menos %1$d caracteres y una combinación de letras y números</item> </plurals>
<plurals name="fui_error_weak_password"> <item quantity="one">La contraseña no es lo suficientemente segura. Usa al menos %1$d carácter y una combinación de letras y números</item> <item quantity="many">La contraseña no es lo suficientemente segura. Usa al menos %1$d de caracteres y una combinación de letras y números</item> <item quantity="other">La contraseña no es lo suficientemente segura. Usa al menos %1$d caracteres y una combinación de letras y números</item> </plurals>
<string name="fui_email_account_creation_error">No se pudo registrar la cuenta de correo electrónico</string>
<string name="fui_terms_of_service">Condiciones del Servicio</string>
<string name="fui_privacy_policy">Política de Privacidad</string>
Expand Down
Loading