fix(auth): stop dropping the user identifier from localized sign-in labels - #2501
Draft
demolaf wants to merge 1 commit into
Draft
fix(auth): stop dropping the user identifier from localized sign-in labels#2501demolaf wants to merge 1 commit into
demolaf wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures and integrates Android Lint checks across modules, introducing a repo-wide lintAll task, updating the CI build script, and documenting the linting policy. It also includes various bug fixes and optimizations, such as optimizing QR code generation to reduce JNI crossings, refining coroutine cancellation in AuthFlowController, updating localized strings with proper placeholders, and adding nullability annotations in the paging source. Feedback suggests explicitly validating the non-null Query parameter in DatabasePagingSource using Objects.requireNonNull to prevent potential null pointer exceptions.
demolaf
force-pushed
the
fix/localized-signed-in-as-identifier
branch
from
September 9, 2026 13:14
8460e8e to
fff04f7
Compare
demolaf
force-pushed
the
ci/run-android-lint-in-the-build
branch
2 times, most recently
from
September 9, 2026 13:35
64ce7cf to
4f2b154
Compare
demolaf
force-pushed
the
fix/localized-signed-in-as-identifier
branch
from
September 9, 2026 13:36
fff04f7 to
c667639
Compare
demolaf
force-pushed
the
fix/localized-signed-in-as-identifier
branch
from
September 9, 2026 13:42
c667639 to
50f0fdd
Compare
demolaf
marked this pull request as draft
September 9, 2026 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
55 locales declared
fui_signed_in_aswithout the%1$sthat the base string andDefaultAuthUIStringProviderboth expect, so users in those locales saw a bare "Signed in as" with nobody named. Every locale now carries the argument, placed where that language puts it.That, plus the localization findings that needed no translator, takes
auth/lint-baseline.xmlfrom 180 entries to 55:values/strings.xml: literal...becomes…, which the locales already use. One of those strings also held a format specifier, and that pairing is what crashedTypographyDetectoron lint's first run here, so fixing the text removes the trigger rather than baselining around it.manyplural get one, derived from each file's ownothertext.AuthExceptionmessages that ship empty becometranslatable="false"— they are override hooks that fall back to the Firebase SDK message, so there is no source text to translate.PluralsCandidateis suppressed withtools:ignoreon the four declarations that trigger it, rather than disabled for the module —minimumPasswordLengthis an unboundedInt, so "at least 1 characters long" is reachable, and the check still needs to guard every other string.What stays baselined is 43
MissingTranslationfindings, real UI copy the Compose rewrite never sent for translation, plus 12 Compose findings tracked separately.Maintainer note: Fixes internal CPRN-432