BE-WAL: the crops were in the table all along, under their names - #259
Merged
Merged
Conversation
ivorbosloper
force-pushed
the
split/be_wal
branch
from
September 11, 2026 20:01
16daa7d to
3df9d70
Compare
This was referenced Sep 11, 2026
ivorbosloper
force-pushed
the
split/be_wal
branch
2 times, most recently
from
September 12, 2026 15:10
40c7912 to
92a27b2
Compare
23,216 of the collection's 341,968 fields — 6.79%, over 59 codes — carried no HCAT code: Jachère, Luzerne, Trèfles, Triticale d'hiver and the cereal mixes among them. They were not missing from EuroCrops' table. That table leaves original_code empty in 208 of its 298 rows and identifies the crop by name there, and the converter matched on the code alone. `ec_mapping_name_fallback` matches on the crop name where the code has no row, and only against rows the table itself leaves uncoded, so a code that is deliberately unmapped stays unmapped. It is off by default and on for be_wal, the only table known to be keyed this way — checked against de.csv, de_nrw_2021.csv, be_vlg_2021.csv, si_2021.csv, dk_2019.csv, lv_2021.csv and fr_2018.csv, none of which has an uncoded row. Names are stripped on both sides: three Walloon crops are spelled with a trailing space in the table, which is the difference between 0.06% and 0.000%. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DVx9uQV2QPM8ecPAY3ZjXG
ivorbosloper
force-pushed
the
split/be_wal
branch
from
September 12, 2026 16:13
92a27b2 to
d3210a1
Compare
ivorbosloper
requested review from
m-mohr and
saidy-moregeo
and removed request for
m-mohr
September 14, 2026 07:24
saidy-moregeo
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6.79% carried no HCAT code — Jachère, Luzerne, Trèfles, Triticale d'hiver. Fix it