SK: the block code is not an id - #245
Merged
Merged
Conversation
This was referenced Sep 11, 2026
ivorbosloper
force-pushed
the
split/sk
branch
from
September 12, 2026 12:51
c763aff to
0a0eec0
Compare
KODKD identifies the LPIS block, not the field: it repeats and is sometimes empty. It is published as `block_id`, and the row index identifies the field. The converter set index_as_id but never named "id" in `columns`, so the base converter's unlisted-column drop removed it again and the collection was published without an identifier at all. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DVx9uQV2QPM8ecPAY3ZjXG
ivorbosloper
force-pushed
the
split/sk
branch
from
September 12, 2026 15:11
0a0eec0 to
1c86c3e
Compare
saidy-moregeo
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update:
KODKDidentifies the LPIS block: it repeats, and is sometimes empty. Generate a unique id