ja: read nPk permutations with the school phrase, in display order - #747
Merged
Conversation
The pochhammer speech rule (reached from the nPk P-notation intents) copied
the en argument reversal and glued 順列の between the arguments, so 5 P 2 was
spoken as 2 順列の 5 — word salad in Japanese. en says "2 permutations of 5"
after Wikipedia's "k-permutations of n"; nb and sv rebuilt the phrase
entirely ("antalet permutationer av 2 element ur 5"). Japanese has a
standard school phrase that reads the notation in display order, so the
reversal is simply not needed: 5 個から 2 個取る順列, "permutations taking
2 out of 5".
The rule is marked audit-ignore the way nb's is, since the x:/T: sequence no
longer mirrors en. A speech test covers the msubsup form in ClearSpeak and
SimpleSpeak. audit-translations: untranslated text 3674 -> 3673, rule
differences 28 -> 28, missing/extra rules 0 -> 0.
This is the item daisy#731's description left alone on purpose (順列の — "the
right Japanese wording is a decision rather than a swap").
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016JCoREgn1pJzcbdnUx4iuh
This was referenced Sep 3, 2026
yasumorishima
added a commit
to yasumorishima/MathCAT
that referenced
this pull request
Sep 3, 2026
daisy#747 has landed, so SharedRules/general.yaml is free to touch. It carries the SimpleSpeak copy of the multi-line labels this branch already fixed in ClearSpeak_Rules.yaml, and leaving it would have made the two styles disagree: ClearSpeak saying ケース and SimpleSpeak ケースケース for the same piecewise. Both rules in general.yaml now read ケース, 式 and 行, and the test asserts the SimpleSpeak path as well as ClearSpeak. The rest of general.yaml (vector, end, sub, the chemistry terms) is a separate batch, not this one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016JCoREgn1pJzcbdnUx4iuh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the item #731's description left alone on purpose: 順列の, where "the right Japanese wording is a decision rather than a swap".
The pochhammer speech rule (reached from the nPk P-notation intents in
Rules/Intent/general.yaml, whose children are [n, k]) copied the en argument reversal and glued 順列の between the arguments, so ⁵P₂ was spoken as 2 順列の 5 — word salad in Japanese. en says "2 permutations of 5" after Wikipedia's "k-permutations of n"; nb and sv rebuilt the phrase entirely ("antalet permutationer av 2 element ur 5"). Japanese has a standard school phrase that reads the notation in display order, so the reversal is simply not needed: 5 個から 2 個取る順列 ("permutations taking 2 out of 5").The rule is marked
audit-ignorethe way nb's is, since the x:/T: sequence no longer mirrors en. A speech test covers the msubsup form in both ClearSpeak and SimpleSpeak — the first test added totests/Languages/ja/ja.rssince the seed. The two:infix:guards and the match are kept identical to en, so nothing else that maps to pochhammer is affected.audit-translations ja: untranslated text 3674 → 3673, rule differences 28 → 28, missing/extra rules 0 → 0.🤖 Generated with Claude Code