ja: fix the navigation announcements, four of which said the opposite - #746
Merged
Merged
Conversation
navigate.yaml is what a blind reader hears on every move, and the seeded
Japanese had not been checked against en. Four announcements had lost the
negation: "no previous row" and "no next row" were 前の行 and 次の行, so at
the top or bottom edge of a table the reader is told "the previous row"
and moves on believing it exists. They now read 前の行はありません and
次の行はありません, and the two column messages beside them are given the
same shape (前の列はありません; 次の列はありません was already right).
Twelve more strings had been replaced by unrelated Japanese words that
happen to start the same way. "inside" was インスタグラム (Instagram),
"read" was フィードバック (feedback), "describe" was コンテンツ (content),
"current" was 最近の投稿 (recent posts), "right" was アクセス (access),
"out" was インフォメーション (information), "move up" was サインアップ
(sign up), "move down" was シフトダウン (shift down), "pre-superscript"
was 事前原稿 (advance manuscript), "enhanced" was 強化強化 (doubled), and
"all of the way" was read as すべての方法 ("by every method"). "inside of
nothing more" was 何もない内部 and now says これ以上内側はありません.
Terms are made consistent: "column" was コラム (a newspaper column) in
eight places and 列 in one, now 列 everywhere; "character" was キャラクター
(a fictional character), now 文字; "part" was パーツ (machine parts), now
部分; "table" was テーブル (furniture), now 表; and "math" was 数学 (the
academic subject) where the file means the expression, now 数式.
One rule is reordered rather than reworded. At the right edge of an
expression the announcement is composed as cannot + move + right, which in
Japanese has to end with the verb; it now emits 右に + 移動 + できません,
matching 右に移動できません that two other rules in this same file already
say as one string.
Per AGENTS.md only these 58 verified lines are promoted from t: to T:.
The rest of the file stays t: — in particular the say-command prefix is
still the English 'zoom'/'move'/'read'/'describe' spoken through
x: "$Prefix" (ru, nb and fr translate it), and getting Japanese word order
there means putting the direction before the verb, so that is its own
change. There are no ja navigation tests yet either; both follow.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016JCoREgn1pJzcbdnUx4iuh
Collaborator
|
sounds good. can't validate the Japanese text itself of course. side note: the shared Claude session has disabled permissions. When I tried to look at it, I got: |
Contributor
Author
|
Thanks. That session link is not viewable outside my account (sharing is off on my side), so it was just noise — I have removed it from this description and from #747, and will leave it out of future PRs. |
Collaborator
|
alright. though including a conversation summary might actually be helpful now that I think about it. |
yasumorishima
added a commit
to yasumorishima/MathCAT
that referenced
this pull request
Sep 3, 2026
Five rule files still carried seed mistranslations of the same kind daisy#746 cleared from navigate.yaml: doubled words, furniture and equipment where mathematics was meant, and English word order glued between Japanese tokens. ClearSpeak multi-line labels: case was ケースケース, step was ステップステップ, equation was 設備 (equipment) and line was ライン; now ケース, ステップ, 式 and 行, in both the count rule and the per-line rule. SharedRules/default.yaml: "table with 3 rows and 4 columns" was テーブルと 3 行 および 4 コラム (the noun first, as in English, and コラム is a newspaper column); it is now 3 行 および 4 列 の表. The menclose line notation was ライン + 左から/アクセス/トップトップ/ボトム ("line" + "from the left" / "access" / "top top" / "bottom"); it is now 左に/右に/上に/下に + 線, side first and the noun last. "with 2 prescripts" was 付き 2 プレスクリプト; it is now 2 個の前置き添字 付き, and the overflow branch's 終了原稿 ("end manuscript", the same seed error family as 事前原稿 in navigate) is 前置き添字終了, with "and alternating prescripts" as および交互の前置き添字. These three are line reorders inside a rule, no lines added or removed. overview.yaml: "the 2 by 3 table" ended in テーブル (furniture); it now ends in の表, the way 行列 is already read. definitions.yaml: "change in" (Δ) was 変更点 ("modification point"), now 変化量. SharedRules/calculus.yaml: ラ・プラハシアン was the en TTS respelling "LahPlahsian" copied as katakana; definitions.yaml already says ラプラシアン, so it does now too. Per AGENTS.md the 22 verified lines are promoted t: -> T:. audit-translations: untranslated text 3674 -> 3652, rule differences 28 -> 28, missing/extra rules 0 -> 0. Two tests cover the multi-line case label and the menclose side line. Left alone on purpose: "such that" (そのようなこと, 4 sites), round (ラウンド値) and fenced-group (フェンスグループ) need a wording decision rather than a swap. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016JCoREgn1pJzcbdnUx4iuh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
navigate.yaml is what a blind reader hears on every move, and it was the one file no PR had touched yet. Checking every
t:line againstenfound ~58 wrong strings, four of which said the opposite of the truth.Announcements that reversed the meaning. "no previous row" and "no next row" had lost the negation — they read 前の行 ("the previous row") and 次の行, so at the edge of a table the reader is told the row exists and acts on it. Now 前の行はありません / 次の行はありません, with the column messages given the same shape.
Unrelated words. The seed replaced several words with lookalikes: "inside" → インスタグラム (Instagram), "read" → フィードバック (feedback), "describe" → コンテンツ (content), "current" → 最近の投稿 (recent posts), "right" → アクセス (access), "out" → インフォメーション (information), "move up" → サインアップ (sign up), "move down" → シフトダウン (shift down), "pre-superscript" → 事前原稿 (advance manuscript), "enhanced" → 強化強化, "all of the way" → すべての方法 ("by every method").
Terms made consistent. "column" was コラム (a newspaper column) in eight places and 列 in one — now 列 everywhere; "character" キャラクター → 文字; "part" パーツ → 部分; "table" テーブル (furniture) → 表; "math" 数学 (the subject) → 数式 (the expression).
One reorder. The right-edge announcement is composed as cannot + move + right; Japanese must end with the verb, so it now emits 右に + 移動/読み上げ/説明 + できません, matching 右に移動できません that this file already says as a single string in three other rules.
Per AGENTS.md the 58 verified lines are promoted
t:→T:; everything else stayst:.audit-translations jabefore/after: untranslated text 3674 → 3616 (exactly −58), missing/extra rules 0 → 0, rule differences 28 → 28, so no rule was added or dropped.Left for follow-up PRs, on purpose: the say-command prefix is still the spoken English
'zoom'/'move'/'read'/'describe'viax: "$Prefix"(ru, nb and fr translate theirs), and fixing it in Japanese also means putting the direction before the verb — a structural change I did not want to mix in here. There are also no ja navigation tests yet.🤖 Generated with Claude Code