Unmount wizard board pollers when the dialog closes - #4438
patrickelectric merged 1 commit into
Conversation
Vuetify keeps dialog content after the first open, so disposeWith never saw _isDestroyed. v-if on should_open destroys the loaders on Close.
Automated PR Review0. Summary
Adds No further comments, nice job 👍 Generated by PR Review Bot. This is advisory, a human reviewer must still approve. |
Helps #4434
Summary
disposeWith: thisis now the Vue instance, but closing the wizard does not destroyScriptLoader/DefaultParamLoader(Vuetify 2 dialog stays booted; stepper content isv-show). The 10sfetchCurrentBoardtasks kept running after Close.v-if="should_open"so Close actually destroys them and the existing OneMoreTime watcher stops the pollers.Test plan
GET /ardupilot-manager/v1.0/boardstops (no pair every ~10s) while staying on home / another page that does not poll the board.param_loader.Tested on smoke-catalog (
192.168.0.124) with this branch served at localhost:8080. After Close, loaders were gone and/boardstayed at 0 hits for 37s (was a pair every 10s before). Re-open + ROV on Customize showed Scripts/Parameter Sets for Navigator64 Sub 4.7.1.validateParams()was false until a set was chosen, then true via$refs.param_loader; Continue was not clicked so firmware was not applied.