Skip to content

[1.4] Unmount wizard board pollers when the dialog closes - #4447

Merged
joaoantoniocardoso merged 1 commit into
bluerobotics:1.4-devfrom
patrickelectric:unmount-wizard-pollers-14
Sep 14, 2026
Merged

joaoantoniocardoso merged 1 commit into
bluerobotics:1.4-devfrom
patrickelectric:unmount-wizard-pollers-14

Conversation

@patrickelectric

Copy link
Copy Markdown
Member

Cherry-pick of #4438

Vuetify keeps dialog content after the first open, so disposeWith never
saw _isDestroyed. v-if on should_open destroys the loaders on Close.

(cherry picked from commit 1498a91)
@github-actions

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Cherry-pick of #4438 to 1.4-dev. Adds v-if="should_open" on the ScriptLoader and DefaultParamLoader children in core/frontend/src/components/wizard/Wizard.vue so they unmount when the wizard dialog closes. Since both use OneMoreTime({ ..., disposeWith: this }) pollers, destroying the components stops the polling — matching the PR's intent.

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

@patrickelectric
patrickelectric requested a review from a team September 14, 2026 17:47
@joaoantoniocardoso
joaoantoniocardoso merged commit 158a7bc into bluerobotics:1.4-dev Sep 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants