ci: restrict GitHub Actions cache access with cache-mode - #169
Merged
Merged
Conversation
Set cache-mode to none at the workflow level and grant each job only what its setup-go and build-push-action caches need: write where a run on main saves the cache pull requests restore (ci.yml, codeql.yml, pages.yml), read where a job only restores it (the release build and the SARIF upload check). codeql.yml also gets the workflow-level permissions block the other workflows already carry, and the convention is documented next to the permissions rule. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKZPpJJVhgvmm2GZbX3nxV
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub now lets a workflow or job declare the cache access it needs with
cache-mode(read,write,write-only,none), enforced by the cache service (changelog, workflow syntax, dependency caching reference). Without it,push,scheduleandworkflow_dispatchruns getwriteby default.This applies the same least-privilege pattern already used for
permissions:cache-mode: noneat the workflow level of every workflow, and a job-level grant only whereactions/setup-go(which caches by default) orbuild-push-actiontype=ghaneeds one.ci.ymltest,lint,docs,dockerflags,dogfoodingwritesetup-gocache saved onmain, restored by pull requestsci.ymldockerwritecache-to: type=ghacodeql.ymlanalyzewritesetup-gocache, CodeQL cachespages.ymlbuildwritesetup-gocache holds the Hugo tool buildrelease.ymlbuildreadmaincache; a save scoped to a tag ref is never restored by another runsarif-upload-check.ymlupload-checkreadci.ymlalready saves the same key onmainnoneAlso:
codeql.ymlgets the workflow-levelpermissions: {}the other workflows already carry (theanalyzejob's own permissions are unchanged).AGENTS.mddocuments the convention next to thepermissions: {}rule.Notes
readjobs skip thesetup-gopost-step save rather than fail.🤖 Generated with Claude Code
https://claude.ai/code/session_01AKZPpJJVhgvmm2GZbX3nxV
Generated by Claude Code