ci: restore binfmt cache reads in the release docker job - #171
Merged
Merged
Conversation
docker/setup-qemu-action keeps the binfmt image in the Actions cache by default (cache-image: true), which cache-mode: none blocked: the job now pulls docker.io/tonistiigi/binfmt on every run. read restores the copy the ci.yml docker job saves on main; the save this job would attempt is scoped to a tag ref no other run restores, so it stays refused. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKZPpJJVhgvmm2GZbX3nxV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #169. A log review of the runs under the new
cache-modesettings found one cache user the workflow files do not show:docker/setup-qemu-actionkeeps thetonistiigi/binfmtimage in the Actions cache by default (cache-image: true). Thedockerjob ofrelease.ymlruns it undercache-mode: none, so the PR dry run of #169 loggedand pulled the image from Docker Hub instead of restoring the copy the
dockerjob ofci.ymlsaves onmain.This sets
cache-mode: readon that job.readis enough: the job only needs to restore themaincopy, and a save from a tag ref would land in a scope no other run restores.Verification
Job logs of the runs before and after #169 were compared for every job whose mode changed (the runner prints
Cache mode: <mode>at job start):writejobs still restore and save as before:setup-goinci.yml,codeql.ymlandpages.yml,type=ghaimport/export and the binfmt cache in theci.ymldockerjob.readjobs restore and skip the save as intended: the releasebuildmatrix andsarif-upload-check.yml.nonejobs show no cache operation, except the one fixed here.🤖 Generated with Claude Code
https://claude.ai/code/session_01AKZPpJJVhgvmm2GZbX3nxV
Generated by Claude Code