Make grafana viewable - #94
Open
jeremyestein wants to merge 7 commits into
Open
Conversation
same docker network as the Emap portal
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #94 +/- ##
=======================================
Coverage 51.42% 51.42%
=======================================
Files 14 14
Lines 595 595
Branches 48 48
=======================================
Hits 306 306
Misses 273 273
Partials 16 16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thompson318
reviewed
Sep 2, 2026
Co-authored-by: Stephen Thompson <s.thompson@ucl.ac.uk>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #92
Allow the "Emap Portal", which is an nginx reverse proxy, to see our grafana container. Serve grafana on a subpath (
/local-grafana/) so that it matches what the browser sees.Tightly coupled to the Emap PR SAFEHR-data/emap#175.