Make grafana viewable - #175
Open
jeremyestein wants to merge 6 commits into
Open
Conversation
PR checklistDefault guide for a PR (if multiple PRs for the work, only keep one version of it and link to it on the other PRs)
|
thompson318
reviewed
Sep 7, 2026
thompson318
left a comment
Contributor
There was a problem hiding this comment.
I couldn't see much wrong with it. I ran it through Claude code which raised a couple of issues with proxy_pass. I've included them as suggestions here. Apologies if they're no use. Let me know if you need more explanation.
thompson318
approved these changes
Sep 10, 2026
jeremyestein
added this pull request to stack #182
September 10, 2026 16:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SAFEHR-data/waveform-controller#92
Tightly coupled to SAFEHR-data/waveform-controller#94
Add Waveform Grafana to the Emap portal reverse proxy.
This is intended to be temporary, as we will have GAE-level grafana (etc) in the near future. Therefore I have not worried about what will happen if the manually-created docker network that connects the containers is absent.