Rename build-results target to results-build - #123
Open
jnasbyupgrade wants to merge 1 commit into
Open
jnasbyupgrade wants to merge 1 commit into
jnasbyupgrade wants to merge 1 commit into
Conversation
Too similar to the existing `results` target by name alone -- easy to mistake one for the other when skimming target names or tab-completing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #109's review: the
build-resultstarget name was flagged astoo easily confused with the existing
resultstarget. Renames it toresults-build, updating every reference:base.mk's target/comments,README.asc(+ regeneratedREADME.html),CLAUDE.md, and the unreleasedHISTORY.ascentry.Paired pgxntool-test PR
Postgres-Extensions/pgxntool-test#88 updates the
make build-resultscallsites in
test/standard/make-test.bats(added by pgxntool-test#79) toresults-build, since those tests invoke the target by name.Dependency note
This branches from
fix-test-build-ordering(#109), which introducedbuild-resultsin the first place. #109 has since merged to master, sothis PR is based on current master and should apply/test cleanly on its
own.
Test plan
test-all) run against this branch pairedwith the corresponding pgxntool-test branch: 258/258 passing, including
both
results-buildBATS tests (issue test-build doesn't gate installcheck: full suite runs before build sanity check #108's coverage, renamed in thepaired PR).
🤖 Generated with Claude Code