Skip to content

Rename build-results target to results-build - #123

Open
jnasbyupgrade wants to merge 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:rename-build-results-to-results-build
Open

jnasbyupgrade wants to merge 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:rename-build-results-to-results-build

Conversation

@jnasbyupgrade

@jnasbyupgrade jnasbyupgrade commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #109's review: the build-results target name was flagged as
too easily confused with the existing results target. Renames it to
results-build, updating every reference: base.mk's target/comments,
README.asc (+ regenerated README.html), CLAUDE.md, and the unreleased
HISTORY.asc entry.

Paired pgxntool-test PR

Postgres-Extensions/pgxntool-test#88 updates the make build-results call
sites in test/standard/make-test.bats (added by pgxntool-test#79) to
results-build, since those tests invoke the target by name.

Dependency note

This branches from fix-test-build-ordering (#109), which introduced
build-results in the first place. #109 has since merged to master, so
this PR is based on current master and should apply/test cleanly on its
own.

Test plan

🤖 Generated with Claude Code

Too similar to the existing `results` target by name alone -- easy to
mistake one for the other when skimming target names or tab-completing.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 01cfa142-a9b4-4fb4-b4dc-aed83304e7e5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant