Update build-results call sites to results-build - #88
Open
jnasbyupgrade wants to merge 2 commits into
Open
jnasbyupgrade wants to merge 2 commits into
jnasbyupgrade wants to merge 2 commits into
Conversation
pgxntool renamed the target for the same reason: too similar to `results`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task
The branch rename that replaced closed PR Postgres-Extensions#87 with Postgres-Extensions#88 kept the same commit, so GitHub's checks-for-ref API still returns Postgres-Extensions#87's cancelled check runs alongside Postgres-Extensions#88's passing ones for that SHA, poisoning the paired-PR check in the pgxntool PR. A fresh SHA avoids the collision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paired with Postgres-Extensions/pgxntool#123, which renames pgxntool's
build-resultstarget toresults-build(review feedback on #109: theold name was too close to the existing
resultstarget). Updates themake build-resultscall sites this repo's own tests added in #79(
test/standard/make-test.bats) toresults-build, so the suite keepsexercising the renamed target instead of a now-nonexistent one.
Replaces #87, which closed automatically when its head branch was renamed
(to match the branch name on the paired pgxntool PR, per this project's CI
pairing convention -- same content, same commit, just a fresh PR object).
Test plan
test-all), this branch paired withjnasbyupgrade/pgxntool#123 via
PGXNBRANCH: 258/258 passing, includingboth renamed
results-buildtests (issue #108's coverage).🤖 Generated with Claude Code