fix(contracts): emit correct newExpiration in UserPayment.until - #2304
Open
erhnysr wants to merge 1 commit into
Open
fix(contracts): emit correct newExpiration in UserPayment.until#2304erhnysr wants to merge 1 commit into
erhnysr wants to merge 1 commit into
Conversation
…notherco#2268) receive() computed newExpiration to validate against maxSubscriptionTimeAhead, but the UserPayment event re-derived block.timestamp + paymentExpirationTimeSeconds instead of using it -- wrong (earlier) 'until' whenever an active subscription is extended, diverging from what's actually stored in subscribedAddresses. Fixes yetanotherco#2268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2268. Added a Foundry test proving the extension case (test_UserPayment_emitsCorrectUntil_onExtendedSubscription) failed before this fix and passes after — the emitted
untilnow matches what's actually stored insubscribedAddresses.