Fix simd reshape lazy view - #2930
Open
Alex-PLACET wants to merge 10 commits into
Open
Conversation
…r signed and unsigned char
…ck#2929) load_simd/store_simd take the address of the view's flat storage, which requires lvalue references. Gate provides_simd_interface on the storage exposing lvalue references so strided views over lazy expressions fall back to the scalar assign path instead of hard-erroring.
Contributor
Merging this PR will degrade performance by 1.66%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | xshape_access[std\:\:array<std\:\:size_t, 4>] |
125.3 ns | 154.4 ns | -18.88% |
| ⚡ | Simulation | xshape_initializer[std\:\:array<std\:\:size_t, 4>] |
180.8 ns | 151.7 ns | +19.23% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing Alex-PLACET:fix-simd-reshape-lazy-view (d8553ad) with master (01798fa)1
Footnotes
Contributor
Author
|
The codspeed benchmark regression report is not related to the modifications. |
Alex-PLACET
marked this pull request as ready for review
August 24, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #2929
provides_simd_interfacenow also requires the storage to expose lvalue references, so lazybacked strided views fall back to the scalar assign path. Container-backed views keep their SIMD path unchanged.