fix: preserve incomplete tool arguments in telemetry - #209
Open
SeanKudrna wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a model reaches its token limit in the middle of a tool call, its arguments can contain incomplete JSON. Both prompt and completion telemetry unconditionally call
json.loads, sochat.sample()raisesJSONDecodeErrorinstead of returning the response. Consumingchat.stream()also raises when it collects final span attributes, and replaying the response fails before the next request.Parse valid arguments as before, but retain the original string in telemetry when decoding fails. This preserves the response for application-level handling without repairing or executing malformed arguments. The existing sensitive-attribute opt-out still applies.
Validation:
uv run ruff format --checkanduv run ruff check: passed.uv run pyright: 0 errors or warnings.uv run pytest -n 4 -q: 843 passed on Python 3.13, with 20 existing batch-API deprecation warnings.Related Issue
N/A. Submitted as a small, localized bug fix under the contribution guide's direct-PR guidance.
Type of Change
Checklist