Skip to content

fix(generated): Changes to multi_factor_auth - #556

Merged
workos-sdk-automation[bot] merged 3 commits into
mainfrom
oagen/batch-666ef9e0
Sep 16, 2026
Merged

workos-sdk-automation[bot] merged 3 commits into
mainfrom
oagen/batch-666ef9e0

Conversation

@workos-sdk-automation

@workos-sdk-automation workos-sdk-automation Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

fix(multi_factor_auth): Change errors for endpoint POST /auth/factors/{id}/challenge

  • Changed errors for endpoint POST /auth/factors/{id}/challenge.

Triggered by workos/openapi-spec@949c30c

BEGIN_COMMIT_OVERRIDE
fix(multi_factor_auth): Change errors for endpoint POST /auth/factors/{id}/challenge (#556)
END_COMMIT_OVERRIDE

…iKeys, AuditLogs, Authorization, ClientApi, Connect, DirectorySync, Events, FeatureFlags, Groups, MultiFactorAuth, OrganizationDomains, OrganizationMembership, Organizations, OrganizationsDataProviders, Pipes, PipesProvider, PlatformTeams, Radar, SSO, UserManagement, Vault, Webhooks, Widgets
@workos-sdk-automation workos-sdk-automation Bot added the autogenerated Autogenerated code or content label Sep 16, 2026
@workos-sdk-automation
workos-sdk-automation Bot requested review from a team as code owners September 16, 2026 19:24
@workos-sdk-automation workos-sdk-automation Bot added the autogenerated Autogenerated code or content label Sep 16, 2026
@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The PR appears safe to merge after non-blocking cleanup of duplicate model definitions and typed webhook dispatch integration.

Findings

  1. P2 Duplicate model constants
  2. P2 Events bypass typed parsing
Fix with agent prompt
### Issue 1
lib/workos/organizations_data_providers/data_integrations_list_response_data.rb:6
This directory defines the same top-level models already defined under the collapsed `pipes` directory. Zeitwerk can register only one source file for each constant, so the other generated implementation is shadowed. This creates two conflicting sources of truth and can silently omit future schema changes made only to the shadowed copy. Keep these shared models in one canonical location.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

### Issue 2
lib/workos/types/create_webhook_endpoint_events.rb:99-103
These new `pipes.account_connection.*` events are not registered in `WebhookEvent::EVENT_DATA_MODELS`. As a result, `construct_event` returns their data as a raw `Hash` even though this PR adds typed models for the payloads. Consumers therefore cannot use those model accessors through the normal webhook parsing path. Register each event with its corresponding data model and cover this dispatch path in a test.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

This generated update documents the MFA SMS-template restriction and expands Pipes and organization data-provider support.

  • Adds an OrganizationsDataProviders client service and associated request/response models.
  • Adds organization-owned connection fields and connected-account metadata.
  • Adds models and enum values for new Pipes account-connection webhook events.
  • Adds corresponding RBI declarations and generated round-trip/request tests.

Reviews (1) · Last reviewed commit: "chore(generated): add release notes frag..."

# This file is auto-generated by oagen. Do not edit.

module WorkOS
class DataIntegrationsListResponseData < WorkOS::Types::BaseModel

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Duplicate model constants

This directory defines the same top-level models already defined under the collapsed pipes directory. Zeitwerk can register only one source file for each constant, so the other generated implementation is shadowed. This creates two conflicting sources of truth and can silently omit future schema changes made only to the shadowed copy. Keep these shared models in one canonical location.

Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/workos/organizations_data_providers/data_integrations_list_response_data.rb
Line: 6

Comment:
**Duplicate model constants**

This directory defines the same top-level models already defined under the collapsed `pipes` directory. Zeitwerk can register only one source file for each constant, so the other generated implementation is shadowed. This creates two conflicting sources of truth and can silently omit future schema changes made only to the shadowed copy. Keep these shared models in one canonical location.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment on lines +99 to +103
PIPES_ACCOUNT_CONNECTION_ADD_FAILED = "pipes.account_connection.add_failed"
PIPES_ACCOUNT_CONNECTION_CONNECTED = "pipes.account_connection.connected"
PIPES_ACCOUNT_CONNECTION_CONNECTION_FAILED = "pipes.account_connection.connection_failed"
PIPES_ACCOUNT_CONNECTION_DISCONNECTED = "pipes.account_connection.disconnected"
PIPES_ACCOUNT_CONNECTION_REAUTHORIZATION_NEEDED = "pipes.account_connection.reauthorization_needed"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Events bypass typed parsing

These new pipes.account_connection.* events are not registered in WebhookEvent::EVENT_DATA_MODELS. As a result, construct_event returns their data as a raw Hash even though this PR adds typed models for the payloads. Consumers therefore cannot use those model accessors through the normal webhook parsing path. Register each event with its corresponding data model and cover this dispatch path in a test.

Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/workos/types/create_webhook_endpoint_events.rb
Line: 99-103

Comment:
**Events bypass typed parsing**

These new `pipes.account_connection.*` events are not registered in `WebhookEvent::EVENT_DATA_MODELS`. As a result, `construct_event` returns their data as a raw `Hash` even though this PR adds typed models for the payloads. Consumers therefore cannot use those model accessors through the normal webhook parsing path. Register each event with its corresponding data model and cover this dispatch path in a test.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

@workos-sdk-automation
workos-sdk-automation Bot merged commit 427e733 into main Sep 16, 2026
8 checks passed
@workos-sdk-automation
workos-sdk-automation Bot deleted the oagen/batch-666ef9e0 branch September 16, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autogenerated Autogenerated code or content

Development

Successfully merging this pull request may close these issues.

0 participants