fix: keep request timeouts active while reading response bodies

[CodingCossack]

Requests could hang indefinitely when a server returned headers but stalled the response body.

Keep the original per-attempt timeout active through body consumption. Preserve the original response object, prevent competing readers from disarming another reader’s deadline, and leave unrelated body-read errors unchanged.

Timeouts while reading error responses remain subject to the existing retry policy, preserving Retry-After and POST idempotency keys. Timeouts while reading successful responses are reported as 408 errors but are not automatically retried.

Validated with deterministic regressions and real HTTP tests using native Fetch and node-fetch 2.7.0. The full suite passes with 1,061 tests, alongside typecheck, lint, formatting and build checks.

Fixes #1679.

[greptile-apps]

Confidence Score: 5/5

The changes since the previous review appear safe to merge, with no accepted new findings or outstanding manually unresolved findings.

Summary

This PR extends each fetch attempt’s timeout through response-body consumption while preserving the original response object and existing retry behavior.

• Reads successful response bodies outside the retry boundary and translates deadline expirations into timeout errors.
• Reads error bodies within the retry boundary so retry headers and POST idempotency behavior remain available.
• Adds deterministic and real-HTTP coverage for native Fetch and node-fetch.
• Restores void deletion methods so they do not parse or require JSON response bodies.
• Documents the body-wide timeout behavior.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Start fetch attempt and deadline] --> B[Receive response headers]
  B --> C{Successful status?}
  C -- No --> D[Read error body within retry attempt]
  D --> E{Body read timed out?}
  E -- Yes --> F[Create 408 with response headers]
  E -- No --> G[Return HTTP error]
  F --> H{Retry policy permits retry?}
  G --> H
  H -- Yes --> A
  H -- No --> I[Surface error]
  C -- Yes --> J[Start body read outside retry boundary]
  J --> K{Caller consumes JSON response?}
  K -- Yes --> L[Await body and parse JSON]
  K -- No --> M[Drain body in background]
  L --> N[Clear deadline]
  M --> N

Loading

_{Reviews (5) · Last reviewed commit: "fix(workos): let delete() complete on th..."}

[gjtorikian]

thanks !