Remove unused Brookesia integration and retain native brightness control - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The board pack contains no Brookesia application, so its optional HAL adapter and application profiles are unused scope. Remove that directory and its dedicated CI while retaining the framework-independent AMOLED brightness helper and every board definition.
integrations/brookesia_hal_custom/, its application defaults, and the adapter-selection CLI and build-matrix dimension.boards/,include/waveshare_amoled.h, component registration, and the Board Manager test application byte-identical to the base. Runtime QSPI brightness control remains available throughwaveshare_amoled_set_brightness().0.1.1for automatic publication after merging. Applications that explicitly selected the removed optional adapter must remove that dependency; ordinary Board Manager applications keep the same API.Validation for
8f7fc09: 22 Python tests, seven release-operation tests, actionlint, metadata/catalog/navigation checks, and Markdown audit passed. The packaged archive contains four board definitions, the unchanged brightness helper, and no framework-adapter directory. All eight local builds passed on this commit, with no Brookesia dependency resolved. All eight PR Actions builds, metadata checks, and the aggregate check also passed on this commit. No hardware-facing source or configuration is changed; physical board testing remains separate.