Remove dead code and ignore build products - #107
Open
susilehtola wants to merge 1 commit into
Open
Conversation
test/ut_main.cxx defines CATCH_CONFIG_MAIN and includes catch2/catch.hpp, the Catch2 v2 API. The project builds against Catch2 v3 and links Catch2WithMain, so the file does not compile and is referenced by no target. Delete it. muraknowles.hpp carried 128 lines of the pre-refactor Mura-Knowles implementation inside `#if 0`, superseded by the transform-based version below it. Git remembers it; the header need not. .gitignore contained a single entry (*.*.swp), so build trees and editor backups showed up as untracked. Cover build directories, object files and archives, and the usual editor and OS cruft. Work in progress under include/ is deliberately left visible. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FDTFYJMQ76iujDFNHzZyXF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/ut_main.cxx defines CATCH_CONFIG_MAIN and includes catch2/catch.hpp,
the Catch2 v2 API. The project builds against Catch2 v3 and links
Catch2WithMain, so the file does not compile and is referenced by no
target. Delete it.
muraknowles.hpp carried 128 lines of the pre-refactor Mura-Knowles
implementation inside
#if 0, superseded by the transform-based versionbelow it. Git remembers it; the header need not.
.gitignore contained a single entry (..swp), so build trees and editor
backups showed up as untracked. Cover build directories, object files and
archives, and the usual editor and OS cruft. Work in progress under
include/ is deliberately left visible.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01FDTFYJMQ76iujDFNHzZyXF