Skip to content

join: skip locale comparison in check_order default mode #14213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sylvestre wants to merge 1 commit into
base: main
Choose a base branch
from
Open

join: skip locale comparison in check_order default mode #14213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/uu/join/src/join.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,13 @@ impl<'a> State<'a> {
return Ok(Some(line));
}

// In Default mode the warning is only emitted when there are
// already unpaired lines, so skip the (potentially expensive)
// locale comparison on every line when no violation is possible yet.
if input.check_order == CheckOrder::Default && (!self.has_unpaired || self.has_failed) {
return Ok(Some(line));
}

let diff = input.compare(self.get_current_key(), line.get_field(self.key));

if diff == Ordering::Greater
Expand Down
Loading