feat(render): preserve native DFF material surface properties and use game light properties on activation - #284
Merged
user-grinch merged 1 commit intoAug 30, 2026
Conversation
CanerKaraca23
force-pushed
the
feat-render-dynamic-surfaceprops
branch
from
August 30, 2026 00:39
b58e892 to
9bbd5fe
Compare
CanerKaraca23
force-pushed
the
feat-render-dynamic-surfaceprops
branch
from
August 30, 2026 00:41
9bbd5fe to
2cb4012
Compare
… game light properties on activation # Conflicts: # resource/dist/ModelExtras.ini # src/features/plate.cpp # src/utils/modelinfomgr.cpp # Conflicts: # resource/dist/ModelExtras.ini # src/utils/modelinfomgr.cpp
Owner
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves the vehicle's native DFF model material surface properties (
ambient,diffuse,specular) when lights are off, preventing glass, lenses, and textures from looking unnaturally dark or flat. When lights are activated, temporarily applies GTA SA's nativems_lightSurfProps(0x8A645C) and restores the original material properties on render reset (ResetEditableMaterials).Changes
material->surfacePropsviam_SurfPropsRestoreEntriesonResetEditableMaterials.*(RwSurfaceProperties *)0x8A645Cwhen lights are ON.material->surfacePropsuntouched when lights are OFF so model materials retain their natural illumination.MaterialAmbientOffandMaterialAmbientOnconfiguration options.