feat(audio): implement dynamic 3D positional audio and distance attenuation for all sounds - #278
Draft
CanerKaraca23 wants to merge 1 commit into
Draft
Conversation
CanerKaraca23
force-pushed
the
feat-audio-3d-positional
branch
from
August 29, 2026 23:53
d1a84c6 to
73a6a6a
Compare
…uation for all sounds # Conflicts: # src/utils/audiomgr.h
CanerKaraca23
force-pushed
the
feat-audio-3d-positional
branch
from
August 30, 2026 01:07
73a6a6a to
aa6819a
Compare
Owner
|
LGTM. Is this tested on both CLEO4 & CLEO5? Last time I checked 4 & 5 behaved slightly differently from one another. |
user-grinch
requested changes
Aug 30, 2026
| CVector playerPos = pPlayer->GetPosition(); | ||
|
|
||
| for (CVehicle *pVeh : CPools::ms_pVehiclePool) { | ||
| if (CVector::Distance(pVeh->GetPosition(), TheCamera.GetPosition()) > 50.0f ) { |
Owner
There was a problem hiding this comment.
This may cause issue when camera detaches from player. Would cause sounds to play in MapEditors for example.
CanerKaraca23
marked this pull request as draft
August 30, 2026 02:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements realistic 3D positional audio and distance attenuation for all ModelExtras sound effects (engine startup/shutdown, indicator relay ticks, air brake hisses, reverse beepers, and switch clicks).
Changes