ci: correct testcontainer pre-pull image lists - #4685
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (15)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2026-05-16T09:08:57.255ZApplied to files:
🔇 Additional comments (3)
WalkthroughThe workflows update Docker image pre-pulls for CI tests. End-to-end workflows upgrade the Ryuk image to Merge Risk: ⚪ Minimal · up to This PR makes localized corrections to CI pre-pull image lists; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
What
Three corrections to the pre-pull lists, each verified against what the suites actually use.
Changes
ryuk:0.11.0->0.14.0ine2e-webapp.ymlande2e-webapp-auth-full.yml. The installed testcontainers hardcodes the image it starts:So those two lines were pre-pulling an image nothing starts, and the one actually used was never pre-pulled. The other three workflows already say 0.14.0.
postgres:17added tounit-tests-webapp.yml. The webapp suite referencesdocker.io/postgres:17across 10 files but onlypostgres:14was pre-pulled.unit-tests-internal.ymlalready pulls both.Electric pinned to its digest in
unit-tests-webapp.yml. The tests runelectricsql/electric:1.2.4@sha256:20da...while the pre-pull asked for the bare tag, so the pre-pull did not necessarily populate the manifest the tests then request.Not changed
The otel collector and s2 images are pulled by other workflows but are not used by the webapp suite, so they are deliberately not added here.
postgresAndRedisTestuses per-test containers by design and needs nothing pre-pulled.