Skip to content

ci: correct testcontainer pre-pull image lists - #4685

Merged
nicktrn merged 2 commits into
ci/prepull-images-on-fork-prsfrom
ci/prepull-list-drift
Aug 19, 2026
Merged

ci: correct testcontainer pre-pull image lists#4685
nicktrn merged 2 commits into
ci/prepull-images-on-fork-prsfrom
ci/prepull-list-drift

Conversation

@nicktrn

@nicktrn nicktrn commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

What

Three corrections to the pre-pull lists, each verified against what the suites actually use.

Changes

ryuk:0.11.0 -> 0.14.0 in e2e-webapp.yml and e2e-webapp-auth-full.yml. The installed testcontainers hardcodes the image it starts:

// testcontainers@11.14.0 build/reaper/reaper.js
: ImageName.fromString("testcontainers/ryuk:0.14.0").string;

So those two lines were pre-pulling an image nothing starts, and the one actually used was never pre-pulled. The other three workflows already say 0.14.0.

postgres:17 added to unit-tests-webapp.yml. The webapp suite references docker.io/postgres:17 across 10 files but only postgres:14 was pre-pulled. unit-tests-internal.yml already pulls both.

Electric pinned to its digest in unit-tests-webapp.yml. The tests run electricsql/electric:1.2.4@sha256:20da... while the pre-pull asked for the bare tag, so the pre-pull did not necessarily populate the manifest the tests then request.

Not changed

The otel collector and s2 images are pulled by other workflows but are not used by the webapp suite, so they are deliberately not added here. postgresAndRedisTest uses per-test containers by design and needs nothing pre-pulled.

@changeset-bot

changeset-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 60d6fa7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fdea497d-926a-45f2-bb91-133356c8984e

📥 Commits

Reviewing files that changed from the base of the PR and between e0ad2a7 and 60d6fa7.

📒 Files selected for processing (5)
  • .github/workflows/e2e-webapp-auth-full.yml
  • .github/workflows/e2e-webapp.yml
  • .github/workflows/unit-tests-internal.yml
  • .github/workflows/unit-tests-packages.yml
  • .github/workflows/unit-tests-webapp.yml
💤 Files with no reviewable changes (2)
  • .github/workflows/unit-tests-internal.yml
  • .github/workflows/unit-tests-packages.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (15)
  • GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal
  • GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-05-16T09:08:57.255Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3642
File: docker/docker-compose.yml:102-102
Timestamp: 2026-05-16T09:08:57.255Z
Learning: When reviewing pinned Docker image digests in docker-compose files, do not flag the top-level OCI image index digest as unverified based on Docker Hub "layers" page URLs. Those pages show architecture-specific manifest digests (one per platform), not the multiplatform index digest. The authoritative check is `docker buildx imagetools inspect <image>:<tag>` — if it returns the same digest with `mediaType: application/vnd.oci.image.index.v1+json`, the digest in the compose file is correct. Example: `electricsql/electric:1.2.4sha256:20da3d0b0e74926c5623392db67fd56698b9e374c4aeb6cb5cadeb8fea171c36` is the valid OCI index for that tag.

Applied to files:

  • .github/workflows/unit-tests-webapp.yml
🔇 Additional comments (3)
.github/workflows/e2e-webapp-auth-full.yml (1)

105-105: LGTM!

.github/workflows/e2e-webapp.yml (1)

81-81: LGTM!

.github/workflows/unit-tests-webapp.yml (1)

102-106: LGTM!


Walkthrough

The workflows update Docker image pre-pulls for CI tests. End-to-end workflows upgrade the Ryuk image to 0.14.0. The webapp unit-test workflow adds PostgreSQL 17 and pins the Electric image to a SHA256 digest. Internal and package unit-test workflows remove the ElectricSQL image pre-pull.

Merge Risk: ⚪ Minimal · up to 60d6f

This PR makes localized corrections to CI pre-pull image lists; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the image corrections, but it omits the template checklist, testing section, changelog, screenshots, and issue reference. Add the required template sections and complete the checklist, testing steps, changelog, screenshots status, and issue reference.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the CI changes to testcontainer pre-pull image lists.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/prepull-list-drift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nicktrn nicktrn self-assigned this Aug 18, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

@nicktrn

nicktrn commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nicktrn
nicktrn merged commit 7529c33 into main Aug 19, 2026
47 checks passed
@nicktrn
nicktrn deleted the ci/prepull-list-drift branch August 19, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants