Skip to content

chore: enable accessibility lint safeguards - #4680

Open
carderne wants to merge 1 commit into
chore/lint-react-correctness-tri-13381from
chore/lint-jsx-a11y-safeguards-tri-13381
Open

chore: enable accessibility lint safeguards#4680
carderne wants to merge 1 commit into
chore/lint-react-correctness-tri-13381from
chore/lint-jsx-a11y-safeguards-tri-13381

Conversation

@carderne

@carderne carderne commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Enable accessibility rules that catch invalid ARIA usage, inaccessible media, and invalid focus behavior before they reach users.

Base: #4679

@changeset-bot

changeset-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 794454a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 27f8f56b-9659-4054-ad43-e66c4671549d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@carderne
carderne force-pushed the chore/lint-jsx-a11y-safeguards-tri-13381 branch from be0c85c to 794454a Compare August 18, 2026 19:58
@pkg-pr-new

pkg-pr-new Bot commented Aug 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@794454a

trigger.dev

npm i https://pkg.pr.new/trigger.dev@794454a

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@794454a

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@794454a

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@794454a

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@794454a

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@794454a

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@794454a

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@794454a

commit: 794454a

@carderne
carderne marked this pull request as ready for review August 18, 2026 21:10

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread .oxlintrc.json
"correctness": "error"
},
"plugins": ["typescript", "import", "react"],
"plugins": ["typescript", "import", "react", "jsx-a11y"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Adding the jsx-a11y plugin also turns on correctness rules that are not listed explicitly

Because categories.correctness is set to error (.oxlintrc.json:3-5), adding "jsx-a11y" to plugins implicitly enables every jsx-a11y rule in the correctness category, not only the ones explicitly listed. The explicit "error" entries (lines 86-106) are therefore mostly redundant, while unlisted correctness rules such as jsx-a11y/lang, jsx-a11y/mouse-events-have-key-events and jsx-a11y/no-noninteractive-tabindex become active silently. I checked the obvious candidates in the repo (only apps/webapp/app/routes/storybook.timeline/route.tsx:231 uses onMouseOver, and it is on a custom Timeline.Row component rather than a DOM element), so I did not find a concrete violation, but this is worth confirming by running pnpm run lint locally since the local checkout has no node_modules and the linter could not be executed during review.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant