Fix AttributeError when encoding an INST opcode - #321
Open
coldwaterq wants to merge 1 commit into
Open
Conversation
`Inst.encode` reads `self.classname`, but the class defines the property as
`cls`. There is no `classname` attribute, so encoding any INST opcode raises:
>>> Inst.create("os", "system").encode()
AttributeError: 'Inst' object has no attribute 'classname'
`Inst.run` uses `self.cls` correctly, so `encode` is simply out of step with
its own class. Every other opcode round-trips through `encode`; INST is the
only one that cannot.
Added a regression test alongside the other opcode tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inst.encodereadsself.classname, but the class defines that property ascls. There is noclassnameattribute, so encoding any INST opcode raises:Inst.runalready usesself.clscorrectly, soencodeis just out of step with its own class. Every other opcode round-trips throughencode; INST is the only one that cannot.Found while walking opcodes of files that are not pickles at all — a file beginning with
idecodes as INST, and re-encoding it to measure how far decoding got hits this.Change
One line in
fickling/fickle.py:self.classname->self.cls.Test
Added
TestOpcodeEncoding::test_inst_encode_round_tripstotest/test_crashes.py, next to the other opcode tests. Verified it fails without the fix and passes with it.