Stop party updates after fatal lifecycle errors - #14
Open
mswilkison wants to merge 1 commit into
Open
mswilkison wants to merge 1 commit into
mswilkison wants to merge 1 commit into
Conversation
Validate ECDSA keygen decommitment part counts before hashing and point decoding. Adapted from public upstream commit 1693884.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retain the first fatal preparation or round-processing error and stop subsequent updates from storing messages or advancing the party. Input-validation and message-storage rejections remain recoverable. Check the expected keygen commitment part count before hashing and point decoding.
Adapted from the public lifecycle and commitment checks in upstream
16938849b0f49bf925ea3902f5fab21b9ea9904b.Validation:
go test -p 1 ./tss ./ecdsa/keygen -run 'TestBaseParty|TestUnmarshalVSSCommitmentPartCount' -count=1passed withGOMAXPROCS=2. Tests cover each fatal-error source, retained error identity, recoverable rejections, normal progression, and valid/invalid commitment shapes. Full owning suites also passed withgo test -p 1 ./tss ./ecdsa/keygen ./ecdsa/signing -count=1 -timeout=30m(keygen completed in about 16 minutes). Formatting, diff checks, and independent patch review passed.