Guard decoder lengths and nullable input fields - #12
Open
mswilkison wants to merge 1 commit into
Open
mswilkison wants to merge 1 commit into
mswilkison wants to merge 1 commit into
Conversation
Validate helper inputs before indexed reads and coordinate-buffer allocation, require a commitment payload, and propagate nil signing point results through the existing error paths. Preserve base proof arities, optional-mode proof serialization, nil-key parameter skips, and valid routing and point encodings. Adapted from upstream commits: f1588ae (WC decoder arity) 8deab46 (sender metadata guards) 1a8e277 (embedded PartyID guards) 8069c6c (SortedPartyIDs.Keys guard) 6e0bcd4 (shared nullable-input guards) 58a131c (commitment minimum parts) cbb8fe4 (commitment boundary coverage) e65fb36 (Gob coordinate allocation bounds) 8acae9a (signing nil-result guards) 1693884 (PartyID.String content guard)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate decoder lengths and nullable helper inputs before indexed reads, coordinate allocation, or dereferencing. Require a commitment payload and propagate nil signing point results through existing error paths. Valid encodings, optional proof serialization, nil-key parameter skips, and existing API signatures are preserved.
Source-level backports of the public upstream input-validation changes; the individual upstream commits are recorded in the commit message.
Validation: bounded input and roundtrip tests plus the complete
tss,crypto,crypto/commitments,crypto/mta, andecdsa/signingpackage suites passed withGOMAXPROCS=2andgo test -p 1. Formatting, diff checks, and independent patch review passed.