Preserve historical proposal outcomes when quorum changes - #196
Draft
mswilkison wants to merge 2 commits into
Draft
mswilkison wants to merge 2 commits into
mswilkison wants to merge 2 commits into
Conversation
…codex/checkpoint-governance-quorum
mswilkison
changed the base branch from
chore/dependency-toolchain-refresh
to
codex/187-slither-upgrade
September 12, 2026 02:04
mswilkison
marked this pull request as draft
September 12, 2026 03:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing quorum currently recalculates old proposals using the latest numerator. An authorized reduction can revive a proposal that failed only for insufficient quorum; an increase can retroactively defeat a queued proposal. Checkpoint quorum numerators and read them at each proposal's snapshot so both governors preserve historical outcomes while future proposals use the updated requirement.
The existing public ABI, current-numerator getter, authorization, events, bounds, and predeployment query behavior are preserved. The implementation reuses the already-pinned OpenZeppelin Checkpoints library.
Addresses the custom-code counterpart of Dependabot #26, CVE-2022-31198. The operator independently confirmed no qualifying proposal is exploitable today. This is a source correction for future deployments; it does not alter the existing mainnet governor or automatically clear a package-version alert.
Stacked on #188 (
codex/187-slither-upgrade, base20a20d5), which is stacked on #182. Merge in order: #182 → #188 → this PR, retargeting each dependent PR after its base merges. Slither 0.8.0 cannot parse the aliased Checkpoints import; the existing scanner upgrade provides Slither 0.11.6 while retaining the detector gate.Validation:
a2be670: all 388 contract tests, formatting, deployment dry run, documentation preview, and Slither 0.11.6 (85 contracts, 95 detectors, zero findings). The baseline annotations come from Upgrade Slither CI to 0.11.6 #188; this PR adds no detector exclusions or suppressions.