chore: prepare threshold-common module rebrand - #34
Closed
mswilkison wants to merge 1 commit into
Closed
mswilkison wants to merge 1 commit into
mswilkison wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the standalone Go module to
github.com/threshold-network/threshold-common, including package/test imports, generator commands, default generated imports, template sources, and embedded templates. Updates repository branding, badges, contribution links, and release instructions. CI now runsgo generate ./...so changes to generator templates are checked too.Draft pending the lifecycle decision in #33. Investigation against the agreed keep-core dev release candidate found that keep-core #4327 already absorbed both runtime code and generators. It has no dependency to migrate here; keep-core #4256 will bring that to main before this work is actioned. Deprecating this standalone fork may be preferable. Merge this PR only if continued standalone maintenance under the Threshold name is chosen.
MIGRATION.mdrecords release ordering, immutable old tags, the different Go module identities, remaining-consumer discovery limits, and the keep-core dev baseline. The repository administration rename and first new-path release (proposedv1.8.0) must be coordinated separately; neither has been performed. Existing tags and dependency versions remain unchanged.Validation on Go 1.26.8:
go generate ./..., followed bygit diff --exit-code: clean, including embedded templates and promise fixtures.go mod tidy -diff: clean.go vet ./...,go build ./..., andgo test ./...: passed across all packages.go list -deps ./...andgo list -m all: resolve the renamed local module without an old common dependency.git diff --check: clean.External download/checksum verification remains a release gate because
threshold-network/threshold-commondoes not exist yet. Historical upstream references remain intentional. The related keep-core migration inventory has been corrected against dev in keep-core #4221.