TAC5572, TAC5682 Support on Intel - #5883
Conversation
|
Can one of the admins verify this patch?
|
Add tac5572, tac5682 to the wake_capable_list as it can generate jack events whilst the bus is stopped. Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
|
test this please |
There was a problem hiding this comment.
Pull request overview
This PR adds support for TI TAC5572/TAC5682 SoundWire smart amplifiers on Intel platforms by enabling the TAC5XX2 SoundWire codec driver in the Intel SoundWire SOF generic machine configuration and by marking these parts as wake-capable in the Intel SoundWire manager.
Changes:
- Select
SND_SOC_TAC5XX2_SDWforSND_SOC_INTEL_SOUNDWIRE_SOF_MACHto ensure TAC5XX2 SDW codec support is built for Intel SoundWire SOF machines. - Add TAC5572/TAC5682 (mfg
0x0102) to the Intel SoundWire wake-capable part list so they can be placed in the wake-capable device-number range.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sound/soc/intel/boards/Kconfig | Enables TAC5XX2 SoundWire codec support for the Intel SoundWire SOF generic machine driver. |
| drivers/soundwire/intel_auxdevice.c | Marks TAC5572/TAC5682 as wake-capable parts for Intel SoundWire manager handling. |
Suppressed comments (1)
sound/soc/intel/boards/Kconfig:540
- The help text for this machine driver lists supported codecs/amplifiers but does not mention the newly selected TAC5XX2 family, which can mislead users about what enabling this option provides.
select SND_SOC_TAC5XX2_SDW
select SND_SOC_DMIC
select SND_SOC_INTEL_HDA_DSP_COMMON
imply SND_SOC_SDW_MOCKUP
help
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| select SND_SOC_ES9356 | ||
| select SND_SOC_TAC5XX2_SDW | ||
| select SND_SOC_DMIC |
There was a problem hiding this comment.
@niranjanhyti Please check the Copilot comment.
There was a problem hiding this comment.
@charleskeepax Do you think we need to select SND_SOC_SDCA here for cs42l45?
There was a problem hiding this comment.
@niranjanhyti Please check the Copilot comment.
I will update it in some time. tac5xx2-sdw driver depends on SND_SOC_SDCA so I think it makes sense
There was a problem hiding this comment.
Hi Bard,
1] Recently I have added 78983d8 which is not there in sof kernel
2] Adding SND_SOC_SDCA is causing the issue
HOSTLD scripts/kconfig/mconf
error: recursive dependency detected!
symbol SOUNDWIRE depends on SND_SOC_SDCA_OPTIONAL
symbol SND_SOC_SDCA_OPTIONAL default value contains SND_SOC_SDCA
symbol SND_SOC_SDCA is selected by SND_SOC_INTEL_SOUNDWIRE_SOF_MACH
symbol SND_SOC_INTEL_SOUNDWIRE_SOF_MACH depends on SND_SOC_SOF_INTEL_SOUNDWIRE
symbol SND_SOC_SOF_INTEL_SOUNDWIRE depends on SOUNDWIRE
For a resolution refer to Documentation/kbuild/kconfig-language.rst
subsection "Kconfig recursive dependency limitations"
make[2]: *** [scripts/kconfig/Makefile:56: menuconfig] Error 1
make[1]: *** [/home/novalake/work/sof/linux/Makefile:766: menuconfig] Error 2
make: *** [Makefile:248: __sub-make] Error 2
There was a problem hiding this comment.
@niranjanhyti Instead of selecting SND_SOC_SDCA, can you try imply SND_SOC_TAC5XX2_SDW? So, the SND_SOC_TAC5XX2_SDW module will be selected when SND_SOC_SDCA is selected.
There was a problem hiding this comment.
@bardliao It doesn't enable CONFIG_SND_SOC_TAC5XX2_SDW even when CONFIG_SND_SOC_SDCA=m with the change
--- a/sound/soc/intel/boards/Kconfig
+++ b/sound/soc/intel/boards/Kconfig
@@ -533,7 +533,7 @@ config SND_SOC_INTEL_SOUNDWIRE_SOF_MACH
select SND_SOC_CS35L56_SPI
select SND_SOC_CS35L56_SDW
select SND_SOC_ES9356
- select SND_SOC_TAC5XX2_SDW
+ imply SND_SOC_TAC5XX2_SDW
$ cat .config | grep -E 'SND_SOC_SDCA|SOC_INTEL_SOUND|TAC5XX'
CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH=m
CONFIG_SND_SOC_SDCA=m
CONFIG_SND_SOC_SDCA_HID=y
CONFIG_SND_SOC_SDCA_IRQ=y
CONFIG_SND_SOC_SDCA_FDL=y
CONFIG_SND_SOC_SDCA_OPTIONAL=m
# CONFIG_SND_SOC_SDCA_CLASS is not set
# CONFIG_SND_SOC_TAC5XX2_SDW is not set
There was a problem hiding this comment.
@niranjanhyti Can you remove CONFIG_SND_SOC_TAC5XX2_SDW from .kconfig and run make olddefconfig? imply is just a suggestion and it will only apply the default value when there is no value set. In other words, if there is a CONFIG_SND_SOC_TAC5XX2_SDW in the .kconfig file already, the kernel will not change the value.
41048c4 to
6526dfa
Compare
Add Texas Instrument's tac5xx2-sdw family to include support for soundwire codecs tac5572, tac5682 Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
6526dfa to
0de3ff8
Compare
TI's TAC5572, TAC5682 Support on Intel.