fix(charging): prevent smallint overflow in energy calculation and recalc migration on battery-side DC readings - #5617
Open
JakobLichterfeld wants to merge 1 commit into
Open
Conversation
…calc migration on battery-side DC readings charger_actual_current and charger_voltage are smallint columns, and PostgreSQL multiplies two smallints into a smallint. Vehicles that write battery-side DC readings into these fields produce products above 32,767 (e.g. 155 A × 230 V), which crashed the recalc migration at boot and — latently since the columns were narrowed in 2020 — the energy calculation at charging completion. Cast the first factor to integer in the migration, determine_phases/1, and the charge-details determine_phases variable; in calculate_energy_used/1 reordering the factors makes the chain float from the first product on. The released migration is edited in place on purpose: installations where it crashed never recorded it and will run the corrected version, installations where it succeeded computed identical values and skip it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
JakobLichterfeld
added
elixir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
charger_actual_current and charger_voltage are smallint columns, and PostgreSQL multiplies two smallints into a smallint. Vehicles that write battery-side DC readings into these fields produce products above 32,767 (e.g. 155 A × 230 V), which crashed the recalc migration (#5592) at boot and — latently since the columns were narrowed in 2020 — the energy calculation at charging completion. Cast the first factor to integer in the migration, determine_phases/1, and the charge-details determine_phases variable; in calculate_energy_used/1 reordering the factors makes the chain float from the first product on.
The released migration is edited in place on purpose: installations where it crashed never recorded it and will run the corrected version, installations where it succeeded computed identical values and skip it.