Link a preview only for pages under cms or cloud - #3473
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
pr: chore
source: repo
Collaborator
Author
|
Perfect! 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR narrows the page the preview link points at, in the workflow added in #3471 and in the
/inki:prskill that writes the same line by hand. Both looked for any.mdor.mdxfile underdocusaurus/docs/, so a PR touching onlydocusaurus/docs/snippets/got a link to a snippet.Only
cms/andcloud/hold pages a reader opens. A snippet is a fragment imported into a page, so a PR that touches nothing else now gets no preview link at all, the same way arepo/PR touching only tooling already did.The rule was not written down anywhere, which is how the 2 implementations ended up agreeing on the wrong thing, so the skill now states it explicitly rather than leaving it implied.