Remove the unused step separator from the NextSteps component - #3470
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
pr: chore
source: repo
pwizla
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the step separator from the
<NextSteps>component, so the rendered result matches what docs.strapi.io shows today and an unlinked step stops rendering as a lone framed box..stepcarried aborder-bottomthat&:last-childwas meant to drop on the last step only. A step that has alinkis wrapped in its own<a class="stepLink">, which makes.stepthe only child there, so the selector matched on every linked step and removed every separator. The border therefore never rendered on the published pages, and the declaration was dead code. It did render in one case: an unlinked step sits directly in.steps, keeps its border, and bleeds past the content width because.stepcarriesmargin: 0 -24px. That is visible on the deployment guides of #3461, where the PM2 step has no link until #3465 adds the page it points to.Making the separator render was tried first and rejected: the line spans the negative margins and cuts across the block. Removing the declaration keeps the current appearance, which is the intended one, and fixes the orphan box.
Direct preview link 👉 here